Skip to content

Conversation

@jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Apr 2, 2024

Description

Drive-by changes

Improve package Readme content

Related issues

Fixes #1354

Backward compatibility

No: package consumers using CJS will need to modify their imports or update to ESM. See this popular gist for details.

Testing

  • CI test coverage which invokes a lot of code via the CLI e2e
  • Manually test in Warp UI by copying packages
  • Publish beta packages and test in a few popular bundlers

@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: 3806e47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/core Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/ccip-server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Merging #3531 (3806e47) into main (040641b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3531   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         16      16           
=====================================
  Misses        16      16           
Components Coverage Δ
core ∅ <ø> (∅)
hooks ∅ <ø> (∅)
isms ∅ <ø> (∅)
token ∅ <ø> (∅)
middlewares ∅ <ø> (∅)

@jmrossy jmrossy mentioned this pull request Apr 4, 2024
Copy link
Contributor

@nbayindirli nbayindirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

thanks for dealing with the shipping and handling on this monstrous pr!

Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@jmrossy jmrossy enabled auto-merge (squash) April 9, 2024 15:19
@jmrossy jmrossy merged commit b63714e into main Apr 9, 2024
@jmrossy jmrossy deleted the rossy/cjs-to-esm branch April 9, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Convert from CJS only to ESM or Hybrid

4 participants