-
Notifications
You must be signed in to change notification settings - Fork 529
Convert packages from CJS to ESM #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes for core package
🦋 Changeset detectedLatest commit: 3806e47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3531 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 16 16
=====================================
Misses 16 16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
thanks for dealing with the shipping and handling on this monstrous pr!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this!
Description
Drive-by changes
Improve package Readme content
Related issues
Fixes #1354
Backward compatibility
No: package consumers using CJS will need to modify their imports or update to ESM. See this popular gist for details.
Testing