-
Notifications
You must be signed in to change notification settings - Fork 207
feat: Add logo and metadata for Terra Classic chain #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughA metadata YAML file for the Terra Classic blockchain has been introduced. It details the chain's configuration, including identifiers, network type, native asset information, gas price, protocol, endpoints, explorer info, and technical stack. This file establishes the necessary on-chain and network metadata for Terra Classic. Changes
Poem
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
chains/terraclassic/metadata.yaml (2)
23-27
: Only one RPC / gRPC / REST endpoint – a single swamp for all trafficWith just one endpoint per transport, any hiccup on that host will bog users down. Consider adding at least one more mirror for each of
rpcUrls
,grpcUrls
, andrestUrls
to give the tooling a fallback path.
28-29
:technicalStack: other
feels vagueIf there’s a more specific bucket (e.g.
cosmos-sdk
), slotting Terra Classic into that keeps the catalogue tidy and searchable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
chains/terraclassic/logo.svg
is excluded by!**/*.svg
📒 Files selected for processing (1)
chains/terraclassic/metadata.yaml
(1 hunks)
🔇 Additional comments (2)
chains/terraclassic/metadata.yaml (2)
18-20
: Gas price string – just make sure we’re not burnin’ extra uluna
"28.325"
is wrapped as a string, which is fine if the schema expects a string. Two quick things to confirm:
- Is
28.325 uluna
the recommended baseline for Columbus-5 right now?- Do sibling Cosmos chains in the repo store this as a
string
or anumber
? Keeping the type consistent avoids foot-blisters later.
3-6
: Swap outfamily: other
for a more specific enumHeh, labeling this explorer as
other
leaves things a bit muddy—if the registry schema defines a more precise family (liketerra_finder
orcosmos
), swapping it in now keeps our dashboards from wading through swamp muck later.
- chains/terraclassic/metadata.yaml
- family: other + family: <schema_enum> # e.g. terra_finder or cosmos
🦋 Changeset detectedLatest commit: 47f80d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a changeset with yarn changeset add
also run the linter/prettier with yarn lint:fix
and yarn prettier
chore: add changeset and run lint/prettier as requested in PR review
Description
Add Terra Classic chain to the registry with corresponding metadata, including chain ID, RPC URLs, block explorer, and native token information.
Backward compatibility
Yes
Testing
Validated metadata with Hyperlane CLI. No deployments performed; only registry metadata was added.
Summary by CodeRabbit