-
Notifications
You must be signed in to change notification settings - Fork 208
feat: add Kadena chain #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add Kadena chain #1040
Conversation
|
📝 WalkthroughWalkthroughA new metadata YAML file for the Kadena blockchain has been added. This file sets out the chain's configuration, including IDs, token details, protocol, RPC URLs, block parameters, explorer info, and gas currency references. Changes
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
chains/kadena/metadata.yaml (1)
23-23
: Mind the trailing newline, friendYAML-lint grumbles that the file ends without a newline. Add one so the linters stay quiet.
-technicalStack: other \ No newline at end of file +technicalStack: other +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
chains/kadena/logo.svg
is excluded by!**/*.svg
📒 Files selected for processing (1)
chains/kadena/metadata.yaml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
chains/kadena/metadata.yaml
[error] 23-23: no new line character at the end of file
(new-line-at-end-of-file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
chains/kadena/metadata.yaml (1)
23-23
: Add the wee newline at EOFThe linter’s grumbling because the file ends without a newline. Slip one in and keep the bots quiet.
technicalStack: other +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
chains/kadena/metadata.yaml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
chains/kadena/metadata.yaml
[error] 23-23: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (2)
chains/kadena/metadata.yaml (2)
22-22
: Mind the incomplete RPC root, laddie
https://api.chainweb.com
is the public host, but Chainweb expects a full path that includes the network (mainnet01
) and chain number (0..19
) for Pact calls. If the tooling blindly appends its own path you’re grand, but if it expects a ready-to-hit endpoint this will return a 404 quicker than a donkey on hot coals.Double-check how Hyperlane composes Kadena requests and, if needed, change the entry to something like:
rpcUrls: - http: https://api.chainweb.com/chainweb/0.0/mainnet01/chain/0/pact
22-22
: Nice fix on the scheme, smells less broken nowYou’ve added the
https://
that was missing in the last round. Tools won’t choke anymore. Good stuff.
<?xml version="1.0" encoding="utf-8"?> | ||
<!-- Generator: Adobe Illustrator 24.0.0, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> | ||
<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" | ||
viewBox="0 0 324.6 312.4" style="enable-background:new 0 0 324.6 312.4;" xml:space="preserve"> | ||
<style type="text/css"> | ||
.st0{fill:#4A9079;} | ||
</style> | ||
<path class="st0" d="M324.6,312.4H211.4l-0.1-0.1l-0.9-0.7L70.3,202.2l57.4-46l196,155.4L324.6,312.4z"/> | ||
<path class="st0" d="M324.6,0H211.4l-0.1,0.1l-0.9,0.7L70.3,110.2l57.4,46l196-155.4L324.6,0z"/> | ||
<path class="st0" d="M70.3,163.1v39v0.1l0,109.4v0.7l-0.1-0.1l-0.9-0.7L1.2,257.7L1,257.6l-1-0.8V55.6l1-0.8l0.2-0.1L69.4,0.7 | ||
l0.9-0.7L70.3,0v0.7l0,109.4v0.1v45.9V163.1z"/> | ||
</svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<?xml version="1.0" encoding="utf-8"?> | |
<!-- Generator: Adobe Illustrator 24.0.0, SVG Export Plug-In . SVG Version: 6.00 Build 0) --> | |
<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" | |
viewBox="0 0 324.6 312.4" style="enable-background:new 0 0 324.6 312.4;" xml:space="preserve"> | |
<style type="text/css"> | |
.st0{fill:#4A9079;} | |
</style> | |
<path class="st0" d="M324.6,312.4H211.4l-0.1-0.1l-0.9-0.7L70.3,202.2l57.4-46l196,155.4L324.6,312.4z"/> | |
<path class="st0" d="M324.6,0H211.4l-0.1,0.1l-0.9,0.7L70.3,110.2l57.4,46l196-155.4L324.6,0z"/> | |
<path class="st0" d="M70.3,163.1v39v0.1l0,109.4v0.7l-0.1-0.1l-0.9-0.7L1.2,257.7L1,257.6l-1-0.8V55.6l1-0.8l0.2-0.1L69.4,0.7 | |
l0.9-0.7L70.3,0v0.7l0,109.4v0.1v45.9V163.1z"/> | |
</svg> | |
<svg xmlns="http://www.w3.org/2000/svg" xml:space="preserve" id="Layer_1" x="0" y="0" style="enable-background:new 0 0 324.6 312.4" version="1.1" viewBox="0 0 324.6 312.4"><style>.st0{fill:#4a9079}</style><path d="M324.6 312.4H211.4l-.1-.1-.9-.7L70.3 202.2l57.4-46 196 155.4.9.8zM324.6 0H211.4l-.1.1-.9.7L70.3 110.2l57.4 46L323.7.8l.9-.8z" class="st0"/><path d="M70.3 163.1v149.2l-.1-.1-.9-.7-68.1-53.8-.2-.1-1-.8V55.6l1-.8.2-.1L69.4.7l.9-.7v163.1z" class="st0"/></svg> |
decimals: 12 | ||
name: coin | ||
symbol: KDA | ||
protocol: kadena |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will not be able to merge this PR until there is support for the kadena
protocol type in the Hyperlane SDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we need to do to make Hypelane SDK to support kadena
protocol?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is your intention to add metadata for kadena itself or the kadena evm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Kadena itself.
Description
Add Kadena chain
Backward compatibility
Testing
Summary by CodeRabbit