-
Notifications
You must be signed in to change notification settings - Fork 214
Add BlockX to Hyperlane Registry #1078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ffc24ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughA new configuration for the BlockX blockchain network has been added. This includes a changeset for updating the registry, a YAML file listing contract addresses, and a metadata YAML describing BlockX's properties, tokens, and explorer info. No code logic or exported entities were changed—just static data and configuration. Changes
Sequence Diagram(s)(Not generating a sequence diagram, as the changes are static configuration additions without new control flow.) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
chains/blockx/metadata.yaml (1)
23-24
: Consider adding extra RPC endpoints for redundancyOnly one HTTP URL is listed. If that single RPC goes for a swamp swim, all on-chain look-ups will stall. Dropping in a backup (or a wss endpoint) keeps things resilient without much fuss.
.changeset/fuzzy-donkeys-rule.md (1)
5-5
: Be a wee bit more descriptive in the changeset bodyA line or two noting that metadata and contract addresses were added helps future ogres understand the patch at a glance. Not mandatory, just nice.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
chains/blockx/logo.svg
is excluded by!**/*.svg
📒 Files selected for processing (3)
.changeset/fuzzy-donkeys-rule.md
(1 hunks)chains/blockx/addresses.yaml
(1 hunks)chains/blockx/metadata.yaml
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: in the hyperlane-registry repository, api keys in chain metadata yaml files (like in chains/*/metada...
Learnt from: xeno097
PR: hyperlane-xyz/hyperlane-registry#788
File: chains/unichain/metadata.yaml:3-4
Timestamp: 2025-07-23T21:28:47.407Z
Learning: In the hyperlane-registry repository, API keys in chain metadata YAML files (like in chains/*/metadata.yaml) are intended for public usage and are not sensitive credentials that need to be hidden.
Applied to files:
chains/blockx/addresses.yaml
chains/blockx/metadata.yaml
🔇 Additional comments (2)
chains/blockx/metadata.yaml (1)
8-10
: Double-check thereorgPeriod
valueMany existing chain entries use an integer (number of blocks) or omit the field. The string
"finalized"
might be perfectly valid in the latest schema, but it’s worth confirming the JSON-schema allows a string here so the CI ogre doesn’t grumble.chains/blockx/addresses.yaml (1)
1-13
: Run an EIP-55 checksum pass on all addressesThe addresses look fine at a glance, but a quick checksum validation script will catch any fat-fingered hex. Better to sniff that out now than chase ghosts later.
Description
Add BlockX to Hyperlane Registry and Requesting Community-Run Infra for BlockX mainnet.
Backward compatibility
Testing
Summary by CodeRabbit