-
Notifications
You must be signed in to change notification settings - Fork 214
feat(bitrock): add chain metadata and core contract addresses #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 36cd83e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughAdds Bitrock chain support to the registry by introducing metadata, core contract addresses, and a README under Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant Reg as Registry Loader
participant Meta as chains/bitrock/metadata.yaml
participant Addr as chains/bitrock/addresses.yaml
participant App as Consumer App
Dev->>Reg: Build/Deploy with new chain
Reg->>Meta: Load chain metadata (id 7171, rpc, explorer)
Reg->>Addr: Load core contract addresses (mailbox, ISMs, hooks...)
Reg-->>App: Provide Bitrock config object
note over Reg,App: New Bitrock support available for runtime/config usage
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.changeset/mighty-dingos-pay.md (1)
6-6
: Remove stray character to avoid changeset parse failure.There’s a lone "6" at EOF that will break
changeset
parsing.feat(bitrock): add chain metadata and core contract addresses -6 +
🧹 Nitpick comments (3)
chains/bitrock/README.md (2)
3-5
: Tighten wording and wrap URLs to satisfy markdownlint.Small polish so the list reads smoother and no bare URLs.
-- Consensus: IBFT-2 PoA (instant finality), ~1s block time -- Explorer: https://explorer.bit-rock.io -- RPC: https://brockrpc.io +- Consensus: IBFT-2 PoA (instant finality, ~1s blocks) +- Explorer: [explorer.bit-rock.io](https://explorer.bit-rock.io) +- RPC: [brockrpc.io](https://brockrpc.io)
7-7
: Link to addresses file for quicker hopping around.Make it clickable.
-Contracts deployed by Hyperlane Core are listed in `addresses.yaml`. +Contracts deployed by Hyperlane Core are listed in [`addresses.yaml`](./addresses.yaml).chains/bitrock/metadata.yaml (1)
3-6
: Capitalize explorer name for consistency.Minor naming polish.
- name: bitrock explorer + name: Bitrock Explorer
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
chains/bitrock/logo.svg
is excluded by!**/*.svg
📒 Files selected for processing (4)
.changeset/mighty-dingos-pay.md
(1 hunks)chains/bitrock/README.md
(1 hunks)chains/bitrock/addresses.yaml
(1 hunks)chains/bitrock/metadata.yaml
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
chains/bitrock/README.md
[grammar] ~3-~3: There might be a mistake here.
Context: ...2 PoA (instant finality), ~1s block time - Explorer: https://explorer.bit-rock.io -...
(QB_NEW_EN)
[grammar] ~4-~4: There might be a mistake here.
Context: ...- Explorer: https://explorer.bit-rock.io - RPC: https://brockrpc.io Contracts depl...
(QB_NEW_EN)
🪛 markdownlint-cli2 (0.17.2)
chains/bitrock/README.md
4-4: Bare URL used
(MD034, no-bare-urls)
5-5: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (4)
.changeset/mighty-dingos-pay.md (1)
1-5
: Changeset looks right otherwise.Package and bump type are correct; message is clear. Ship it once the EOF fix lands.
chains/bitrock/metadata.yaml (2)
7-11
: Good: domainId matches chainId and testnet flag is explicit.This lines up with registry conventions. Nice and tidy.
18-19
: Retain “other” for technicalStack
The schema’s enum for technicalStack includes “other” but doesn’t list “evm,” so no change is needed to avoid CI errors.Likely an incorrect or invalid review comment.
chains/bitrock/addresses.yaml (1)
1-13
: Address sanity checks passed. All 13 entries are valid hex addresses, no duplicates detected, and mailbox/proxyAdmin/validatorAnnounce keys are present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
chains/bitrock/README.md (3)
1-1
: Include chainId in the title for quick scanning.Helps folks spot domain/chain at a glance.
Apply:
-# Bitrock (domain 7171) +# Bitrock (chainId 7171, domain 7171)
3-5
: Add token and protocol bullets; tiny wording nit.Round out basics and smooth the “~1s” phrasing.
Apply:
- Consensus: IBFT-2 PoA (instant finality, ~1s block time) +- Protocol: Ethereum (IBFT-2 PoA) - Explorer: [explorer.bit-rock.io](https://explorer.bit-rock.io) - RPC: [brockrpc.io](https://brockrpc.io) +- Native token: BROCK (18 decimals)Optional wording tweak:
- IBFT-2 PoA (instant finality, ~1s block time) + IBFT-2 PoA (finalizes immediately, ~1 s block time)
7-7
: Surface a key address (Mailbox) right here.Handy for quick validation while browsing.
Apply:
-Contracts deployed by Hyperlane Core are listed in [`addresses.yaml`](./addresses.yaml). +Contracts deployed by Hyperlane Core are listed in [`addresses.yaml`](./addresses.yaml). + +Example: +- Mailbox: `0x516c2087AFd06843609460543E6b70b57ABaE35b`
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
chains/bitrock/README.md
(1 hunks)chains/bitrock/metadata.yaml
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- chains/bitrock/metadata.yaml
🧰 Additional context used
🪛 LanguageTool
chains/bitrock/README.md
[grammar] ~3-~3: There might be a mistake here.
Context: ...2 PoA (instant finality, ~1s block time) - Explorer: [explorer.bit-rock.io](https:/...
(QB_NEW_EN)
🔇 Additional comments (2)
chains/bitrock/README.md (2)
1-7
: Clean, straight-ahead README.Simple and useful. Nice and tidy.
1-7
: Everything checks out. Onlychains/bitrock/metadata.yaml
defines chainId/domainId 7171, and all entries inaddresses.yaml
are valid 0x-prefixed, 40-hex addresses.
Description
Add Bitrock chain (domain 7171) to the Hyperlane registry.
• Consensus: IBFT-2 Proof of Authority (instant finality, ~1s block time)
• Native token: BROCK (18 decimals)
• Explorer: Bitrock Explorer
• RPC: https://brockrpc.io
Includes deployed Hyperlane core contract addresses in addresses.yaml.
Backward compatibility
Yes — No existing chain configs are modified. This change is purely additive.
Testing
• Deployed Hyperlane core contracts to Bitrock using the CLI.
• Verified dispatch + relay of loopback messages (bitrock → bitrock) with the TestRecipient contract.
• Confirmed RPC and explorer configs function correctly in CLI.
• Transactions confirm under legacy gas settings.
Example: Mailbox contract deployed at 0x516c2087AFd06843609460543E6b70b57ABaE35b.
Summary by CodeRabbit
New Features
Documentation
Chores