-
Notifications
You must be signed in to change notification settings - Fork 93
Enabling Worker-pool for standalone build #646
base: main
Are you sure you want to change the base?
Enabling Worker-pool for standalone build #646
Conversation
if [ $START_STOP_AVALON_SERVICES = 1 ] ; then | ||
echo "Starting Avalon Listener $VERSION ..." | ||
is_sync_mode | ||
is_sync_mode_on=$? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why to use is_sync_mode_on when there is is_sync_mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, after making spelling corrections.
scripts/tcs_startpool.sh
Outdated
allPorts=("bind zmq_url remote_storage_url") | ||
for i in $allPorts ; do | ||
# Port number of listerner, zmq and kv storage is picked from listener toml file. | ||
# grep command reads the line as string from toml file which contails url.eg: bind = "http://localhost:1947". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/contails url.eg/contains the url. E.g./
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
scripts/tcs_startpool.sh
Outdated
for i in $allPorts ; do | ||
# Port number of listerner, zmq and kv storage is picked from listener toml file. | ||
# grep command reads the line as string from toml file which contails url.eg: bind = "http://localhost:1947". | ||
# awk command seperates the string into 3, based on ":" such as "http,//localhost,1947". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/seperates/separates/
s/into 3,/into 3 parts,/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
scripts/tcs_startpool.sh
Outdated
|
||
allPorts=("bind zmq_url remote_storage_url") | ||
for i in $allPorts ; do | ||
# Port number of listerner, zmq and kv storage is picked from listener toml file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/listerner/listener/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
scripts/tcs_startpool.sh
Outdated
mv $TCF_HOME/config/wpe_config.toml{.b,} | ||
fi | ||
|
||
# Changing library name in wpe_config.toml file to support mutiple Workerpool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/mutiple/multiple/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
scripts/tcs_startpool.sh
Outdated
KME_URL="http://localhost:"$PORT | ||
|
||
# START_STOP_AVALON_SERVICES doesn't control enclave manager. It will be | ||
# once enclave manager runs as seperate container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/seperate/separate/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
scripts/tcs_startpool.sh
Outdated
WORKER="kme-worker-"$WORKER_ID | ||
echo $WORKER | ||
# START_STOP_AVALON_SERVICES doesn't control enclave manager. It will be | ||
# once enclave manager runs as seperate container. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/seperate/separate/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
scripts/tcs_startpool.sh
Outdated
# Saving the original file with .b extension and rewriting the new library name | ||
echo "Writing to config file" | ||
cp $TCF_HOME/config/wpe_config.toml $TCF_HOME/config/wpe_config.toml.b | ||
# Check line by line and replace enclave lib file name appended with interger COUNT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/interger/integer/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
51a9d8b
to
23ada1b
Compare
Signed-off-by: Karthika Murthy <[email protected]>
Signed-off-by: Karthika Murthy [email protected]