Skip to content
This repository was archived by the owner on Jan 27, 2022. It is now read-only.

Conversation

karthikamurthy
Copy link
Contributor

Signed-off-by: Karthika Murthy [email protected]

if [ $START_STOP_AVALON_SERVICES = 1 ] ; then
echo "Starting Avalon Listener $VERSION ..."
is_sync_mode
is_sync_mode_on=$?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why to use is_sync_mode_on when there is is_sync_mode?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is shell convention to call function. @51 function call to is_sync_mode and @52 is variable name to capture the return value of function is_sync_mode.

Copy link
Contributor

@danintel danintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, after making spelling corrections.

allPorts=("bind zmq_url remote_storage_url")
for i in $allPorts ; do
# Port number of listerner, zmq and kv storage is picked from listener toml file.
# grep command reads the line as string from toml file which contails url.eg: bind = "http://localhost:1947".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/contails url.eg/contains the url. E.g./

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

for i in $allPorts ; do
# Port number of listerner, zmq and kv storage is picked from listener toml file.
# grep command reads the line as string from toml file which contails url.eg: bind = "http://localhost:1947".
# awk command seperates the string into 3, based on ":" such as "http,//localhost,1947".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/seperates/separates/

s/into 3,/into 3 parts,/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


allPorts=("bind zmq_url remote_storage_url")
for i in $allPorts ; do
# Port number of listerner, zmq and kv storage is picked from listener toml file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/listerner/listener/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

mv $TCF_HOME/config/wpe_config.toml{.b,}
fi

# Changing library name in wpe_config.toml file to support mutiple Workerpool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/mutiple/multiple/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

KME_URL="http://localhost:"$PORT

# START_STOP_AVALON_SERVICES doesn't control enclave manager. It will be
# once enclave manager runs as seperate container.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/seperate/separate/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

WORKER="kme-worker-"$WORKER_ID
echo $WORKER
# START_STOP_AVALON_SERVICES doesn't control enclave manager. It will be
# once enclave manager runs as seperate container.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/seperate/separate/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

# Saving the original file with .b extension and rewriting the new library name
echo "Writing to config file"
cp $TCF_HOME/config/wpe_config.toml $TCF_HOME/config/wpe_config.toml.b
# Check line by line and replace enclave lib file name appended with interger COUNT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/interger/integer/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@karthikamurthy karthikamurthy force-pushed the workerpool branch 2 times, most recently from 51a9d8b to 23ada1b Compare July 30, 2020 05:14
@karthikamurthy karthikamurthy added the enhancement New feature or request label Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants