Skip to content

Conversation

@pandaio22
Copy link
Contributor

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@pandaio22 pandaio22 force-pushed the satp-validate-bundle-names-fix branch from b10faae to c025104 Compare October 18, 2025 16:57
@pandaio22 pandaio22 marked this pull request as ready for review October 19, 2025 10:38
@pandaio22 pandaio22 requested a review from LordKubaya as a code owner October 19, 2025 10:38
Copy link
Contributor

@LordKubaya LordKubaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreAugusto11
Copy link
Contributor

@pandaio22 please merge into a single commit without the "Merge"

@RafaelAPB RafaelAPB added this to the SATP-Hermes v0.0.4-beta milestone Oct 20, 2025
@RafaelAPB RafaelAPB added IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force. enhancement New feature or request labels Oct 20, 2025
@LordKubaya
Copy link
Contributor

Rebase this branch please

Signed-off-by: Rodolfo Carapau <[email protected]>

fix(satp-hermes): fixed validate bundle names err

Signed-off-by: Rodolfo Carapau <[email protected]>
@pandaio22 pandaio22 force-pushed the satp-validate-bundle-names-fix branch from 7714d23 to 99ac2cf Compare October 26, 2025 13:37
Copy link
Contributor

@LordKubaya LordKubaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreAugusto11 AndreAugusto11 enabled auto-merge (rebase) October 26, 2025 18:35
@LordKubaya LordKubaya changed the title fix(satp-hermes): fixed validate bundle names err fix(satp-hermes): fix validate bundle names err Oct 27, 2025
@LordKubaya LordKubaya disabled auto-merge October 27, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request IETF-SATP-Hermes Related to the Secure Asset Transfer Protocol as defined by the Internet Engineering Task Force.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants