BE-447 | fetch latest block time to get channels updation time[backend] #449
Conversation
app/platform/fabric/Proxy.ts
Outdated
| } | ||
|
|
||
| getLatestBlockTime(channel, currentTime) { | ||
| let curBlockTime: any; |
There was a problem hiding this comment.
Can you be specific about the data type instead of any.
app/platform/fabric/Proxy.ts
Outdated
| return channel_genesis_hash; | ||
| } | ||
|
|
||
| getLatestBlockTime(channel, currentTime) { |
There was a problem hiding this comment.
Please provide the doc section for the function.
| */ | ||
| async getChannelsInfo(network_name) { | ||
| async getChannelsInfo(network_name, channel_genesis_hash) { | ||
| const currentTime = queryDatevalidator(network_name, channel_genesis_hash); |
There was a problem hiding this comment.
Why do we need queryDateValidator for network_name and channel_genesis_hash
| * @memberof CRUDService | ||
| */ | ||
| async getChannelsInfo(network_name) { | ||
| async getChannelsInfo(network_name, channel_genesis_hash) { |
There was a problem hiding this comment.
Parameter mismatch when the function is called.
| if (page == 1) { | ||
| let sqlTxCount: string; | ||
| const filterValues = [blockNum, txid, channel_genesis_hash, network_name, from, to]; | ||
| const filterValues = [ |
There was a problem hiding this comment.
Please take care of formatting, as it shouldnt disturb the oriniginal formatting of the file.
| * @memberof CRUDService | ||
| */ | ||
| async getChannelsInfo(network_name) { | ||
| async getChannelsInfo(network_name, channel_genesis_hash) { |
There was a problem hiding this comment.
As I see these are the changes to the existing function, please note that it shouldnt impact the application, if this function is called by any other functions.
| ); | ||
|
|
||
| return channels; | ||
| return { channels, currentTime }; |
There was a problem hiding this comment.
Why do we need to send current time from here
app/platform/fabric/Proxy.ts
Outdated
| let agoTime = ''; | ||
| if (!channel?.latestdate) return agoTime; | ||
| curBlockTime = channel.latestdate; | ||
| const dateCurBlock = new Date(curBlockTime); |
There was a problem hiding this comment.
It will be good enough to give a meaningful name to the variables like currentBlockDate
3 participants
What this PR does / why we need it:
To achieve channels updation time on page load, the latest block time needs to be fetched to determine how long ago the channels were updated.
Which issue(s) this PR fixes:
Fixes #447
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation, usage docs, etc.: