endpoint.Service: Bind multiple ephemeral identities at the same time #1009 #1033
+712
−394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HayimShaul
force-pushed
the
1009-unite-multiple-binds-2
branch
from
312e46b to
5625f77
Compare
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestPutBindings_MultipleEphemerals(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestPutBindings_MultipleEphemerals(t *testing.T) { | |
| func TestPutBindingsMultipleEphemerals(t *testing.T) { |
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestPutBindings_MultipleEphemerals(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestPutBindings_MultipleEphemerals(t *testing.T) { | |
| func TestPutBindingsMultipleEphemerals(t *testing.T) { |
| query += strings.Join(argsReferences, ", ") | ||
| query += " ON CONFLICT DO NOTHING;" | ||
|
|
||
| logger.DebugfContext(ctx, "executing bulk insert: %s", query) |
There was a problem hiding this comment.
I am wondering if this should be really a debug message that also appears as tracing events.
This is a general questions for all logger.InfofContext in this PR. I would add tracing events only if you would gain additional knowledge in order to follow / understand the timing in traces. I think the traces should not be used as general log.
There was a problem hiding this comment.
This is how it was before the changes I made.
Are you sure no one is expecting these in the trace?
Maybe handle this in a different PR?
There was a problem hiding this comment.
Indeed, @mbrandenburger , we need to address this in a dedicate Issue/PR
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
2. fixed postgres test Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
HayimShaul
force-pushed
the
1009-unite-multiple-binds-2
branch
from
674d885 to
2cd3a22
Compare
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to allow the binding of multiple identities at the same time so to same in the number of DB connections when binding multiple identities. This will be used in the token-sdk.