fix: Extend logger name replacer #1062
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace all fsc packages with `fsc` prefix. Signed-off-by: Marcus Brandenburger <[email protected]>
mbrandenburger
force-pushed
the
logging-replacer
branch
from
95b0b90 to
267a0b3
Compare
mbrandenburger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logging framework uses a full package name for the logger name. With the replacer we can shorten the logger name.
By default, we use a replacer for
github.com.hyperledger-labs.fabric-smart-client.platform. While this works well for the platform package, there are other packages, such asintegration/nwo,pkg, which may benefit from shorter logger names.Therefore, this PR replace all fsc loggers names with
fscprefix.