Skip to content

Conversation

@meiersi-da
Copy link
Contributor

Simon's version of

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Merge pull request #3091 from hyperledger-labs/meiersi/upgrade-cip73-branch
dfordivam and others added 27 commits November 7, 2025 06:17
Signed-off-by: Divam <[email protected]>
Signed-off-by: Divam <[email protected]>
Signed-off-by: Divam <[email protected]>
Just to make the code compile

Signed-off-by: Divam <[email protected]>
Signed-off-by: Divam <[email protected]>
Co-authored-by: Simon Meier <[email protected]>
Signed-off-by: Divam <[email protected]>
Co-authored-by: Simon Meier <[email protected]>
Signed-off-by: Divam <[email protected]>
Co-authored-by: Simon Meier <[email protected]>
Signed-off-by: Divam <[email protected]>
…alance change checks

This has no transferFee and holdingFee, and makes it easier to confirm the cases
where user's account balance change is not expected.

Signed-off-by: Divam <[email protected]>
@meiersi-da meiersi-da force-pushed the dn/cip-0073-daml-weighted-validator-license branch from af744e3 to 389dce7 Compare November 7, 2025 07:58
@mergify
Copy link

mergify bot commented Nov 7, 2025

⚠️ The sha of the head commit of this PR conflicts with #2903. Mergify cannot evaluate rules on this PR. ⚠️

Signed-off-by: Simon Meier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants