Perf: report committed goodput separately from submission throughput - #173
Open
kushnireyal wants to merge 2 commits into
Open
Perf: report committed goodput separately from submission throughput #173kushnireyal wants to merge 2 commits into
kushnireyal wants to merge 2 commits into
Conversation
kushnireyal
marked this pull request as ready for review
May 13, 2026 05:30
kushnireyal
force-pushed
the
eyal/perf-goodput-accounting
branch
2 times, most recently
from
May 21, 2026 08:04
8a1fb13 to
c8a0f3d
Compare
This commit enhances performance testing by distinguishing between: - Goodput: Successfully committed transactions per second - Submission throughput: All attempted transactions per second (including invalidated) Key changes: - Add invalidatedCount tracking to distinguish MVCC conflicts from successful commits - Check receipt status to differentiate committed (status=1) vs invalidated (status=0) transactions - Update return signature to include invalidated transaction count - Enhance logging to show both goodput and submission metrics - Add //go:build perf tag for proper test isolation - Clean up imports (remove unused gwtestimpl) - Simplify balancePrimingEndorserFactory implementation - Remove wrapCount field in favor of direct totalDispatches calculation Signed-off-by: Eyal Kushnir <Eyal.Kushnir@ibm.com>
kushnireyal
force-pushed
the
eyal/perf-goodput-accounting
branch
from
May 21, 2026 08:19
c8a0f3d to
d187d47
Compare
# Conflicts: # integration/perf/replay_json_dataset_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #56 (Measure Goodput Rate).
Reports goodput (successfully committed tx/s) separately from submission throughput (all attempted tx/s), by inspecting receipt status to classify each transaction as committed / invalidated / failed. This gives the committed-vs-attempted ratio #56 asks for.
Depends on #169. Please do not review until that is merged— #169 is now merged, so this is ready for review.