test: add go-test-json baseline support for execution-specs suite - #289
Open
arner wants to merge 1 commit into
Open
test: add go-test-json baseline support for execution-specs suite#289arner wants to merge 1 commit into
arner wants to merge 1 commit into
Conversation
Adds a go test -json parser to cmd/baseline (ParseGoTestJSON) and wires up a new eth-tests-execution-specs suite, mirroring the existing OZ Hardhat mocha-json baseline: known failures tracked per-subtest in testdata/eth_known_failures.json instead of a whole-file skip list. Trims testdata/execution_specs_tests.skip down to only the one file that panics (confirmed via a real run: an unrecovered panic crashes the whole go test process, unsafe for the per-subtest baseline model to represent) -- the other 9 known-bad files now run and their failures are tracked in the baseline instead. Wires testdata/execution-specs-tests fixture caching, a real (non-suppressed) baseline-check gate, and per-PR execution into the execution-specs-tests CI job. Signed-off-by: Arne Rutjes <arne123@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 24.80% 25.17% +0.37%
==========================================
Files 74 74
Lines 10736 10803 +67
==========================================
+ Hits 2663 2720 +57
- Misses 7842 7849 +7
- Partials 231 234 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ OZ Hardhat Compatibility — 84.1% passing (4755/5652)No regressions, no stale entries. Full breakdown — 4755 passed, 896 failed, 1 skipped (5652 total, 84.1% passing)By suite
Expected failures by cause (896)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a go test -json parser to cmd/baseline (ParseGoTestJSON) and wires up a new eth-tests-execution-specs suite, mirroring the existing OZ Hardhat mocha-json baseline: known failures tracked per-subtest in testdata/eth_known_failures.json instead of a whole-file skip list.
Trims testdata/execution_specs_tests.skip down to only the one file that panics (confirmed via a real run: an unrecovered panic crashes the whole go test process, unsafe for the per-subtest baseline model to represent) -- the other 9 known-bad files now run and their failures are tracked in the baseline instead.
Wires testdata/execution-specs-tests fixture caching, a real (non-suppressed) baseline-check gate, and per-PR execution into the execution-specs-tests CI job.