Skip to content

unify synchronizer, update config structure - #360

Merged
arner merged 1 commit into
hyperledger:mainfrom
arner:single-synchronizer
Sep 3, 2026
Merged

unify synchronizer, update config structure#360
arner merged 1 commit into
hyperledger:mainfrom
arner:single-synchronizer

Conversation

@arner

@arner arner commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Committer is now a top level config key. The App has a single synchronizer, instead of having one for the endorser (world state) path and another for the gateway (block/tx store) path.

Signed-off-by: Arne Rutjes <arne123@gmail.com>
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 68.00000% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.71%. Comparing base (f95dd8c) to head (4b381d4).

Files with missing lines Patch % Lines
gateway/app/app.go 50.00% 8 Missing and 1 partial ⚠️
gateway/config/config.go 33.33% 4 Missing ⚠️
endorser/app/factory.go 0.00% 2 Missing ⚠️
integration/split_endorsers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
+ Coverage   36.62%   36.71%   +0.09%     
==========================================
  Files          82       82              
  Lines       11652    11661       +9     
==========================================
+ Hits         4267     4281      +14     
+ Misses       7042     7038       -4     
+ Partials      343      342       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Perf Smoke — CI baseline (lower-bound against test committer)

Metric Value
Throughput 495.35 tx/s
Invalid rate 0.000000
Conflict rate 0.000000

Workflow run

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

🎉 OZ Hardhat Compatibility — 12 tests fixed!

Stale baseline entries (12) — remove these

  • AccessManager admin operations subject to a delay #setRoleAdmin restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • AccessManager admin operations subject to a delay #setRoleGuardian restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • AccessManager admin operations subject to a delay #setGrantDelay restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • AccessManager admin operations subject to a delay #setTargetAdminDelay restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • AccessManager admin operations not subject to a delay #setTargetFunctionRole restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • AccessManager admin operations not subject to a delay role admin operations #grantRole restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • UUPSUpgradeable upgrade to upgradeable implementation with call
  • ERC721Wrapper onERC721Received mints a token to from
  • Create2 deploy deploys a contract without constructor
  • GovernorProposalGuardian using $ERC20Votes "before each" hook for "deployment check"
  • GovernorProposalGuardian using $ERC20VotesTimestampMock cancel proposal during active state "before each" hook for "from proposal guardian"
  • GovernorProposalGuardian using $ERC20VotesTimestampMock set proposal guardian from governance
Full breakdown — 5515 passed, 869 failed, 1 skipped (6385 total, 86.4% passing)

By suite

  • access: 408/603 passing (68%)
  • crosschain: 44/48 passing (92%)
  • finance: 8/16 passing (50%)
  • governance: 241/523 passing (46%)
  • metatx: 26/32 passing (81%)
  • proxy: 287/320 passing (90%)
  • token: 1799/1882 passing (96%)
  • utils: 2702/2960 passing (91%)

Expected failures by cause (607)

  • max-code-size: 212
  • execution reverted: 129
  • hardhat-time-rpc: 93
  • fixed-timestamp: 35
  • subcall-effect-lost: 31
  • fixed-block-number: 23
  • hardhat_setStorageAt: 17
  • gas required exceeds allowance (10000000): 12
  • eth_getProof: 6
  • no private key available for address 0x5401d7362F426a4BC700f1284FFBa6C409A1F18e: 5
  • Expected transaction to be reverted with custom error 'FailedCall', but it reverted with custom error 'TimelockUnexpectedOperationState': 4
  • Expected transaction to be reverted with custom error 'InvalidAccountNonce', but it reverted with custom error 'ERC3009InvalidAuthorizationTime': 4
  • evm_setAutomine: 3
  • execfailure-dropped-not-committed: 3
  • hardhat_setBalance: 3
  • no private key available for address 0x28C82f0652e14492ca5E218c7d42ACff0Cb64Ba9: 3
  • out of gas: 3
  • transaction already pending: 3
  • Expected transaction to be reverted with custom error 'FailedCall', but it didn't revert: 2
  • estimate-gas-allowance-not-revert: 2
  • no private key available for address 0x0B306BF915C4d645ff596e518fAf3F9669b97016: 2
  • no private key available for address 0x6732128F9cc0c4344b2d4DC6285BCd516b7E59E6: 2
  • Expected transaction to be reverted with custom error 'ERC3009InvalidAuthorizationTime', but it didn't revert: 1
  • Expected transaction to be reverted with custom error 'TimelockUnexecutedPredecessor', but it reverted with custom error 'TimelockUnexpectedOperationState': 1
  • Expected transaction to be reverted with panic code 0x01 (Assertion error), but it reverted with a custom error: 1
  • could not decode result data (value="0x", info={ "method": "getValue", "signature": "getValue()" }, code=BAD_DATA, version=6.16.0): 1
  • expected '0x872ed20f447cb20938fb0bc1e0583b01da6…' to equal '0xfdd7c1cc1cf160902b85daaac050e5369e5…': 1
  • expected 36000 to equal 4919.: 1
  • expected 4919 to equal 0.: 1
  • hardhat-block-rpc: 1
  • hardhat_impersonateAccount: 1
  • no private key available for address 0xc6e7DF5E7b4f2A278906862b61205850344D4e7d: 1

Lock in the win — run go run ./cmd/baseline update --suite oz-hardhat and commit the updated baseline to remove these.

@arner
arner merged commit 19a597f into hyperledger:main Sep 3, 2026
8 checks passed
@arner
arner deleted the single-synchronizer branch September 3, 2026 10:09
Siddhartha-singh01 added a commit to Siddhartha-singh01/fabric-x-evm that referenced this pull request Sep 3, 2026
Keep BlockFeed in the handler chain and FilterAPI wiring while adopting
main's NewSynchronizer / synchronizer field from hyperledger#360.

Signed-off-by: Siddhartha Singh <siddharthagithub0007@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants