Skip to content

fix: invalid eth or fabric tx cannot have logs - #362

Open
arner wants to merge 1 commit into
hyperledger:mainfrom
arner:fix-logs
Open

fix: invalid eth or fabric tx cannot have logs#362
arner wants to merge 1 commit into
hyperledger:mainfrom
arner:fix-logs

Conversation

@arner

@arner arner commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

As discovered in #340 (comment)

Signed-off-by: Arne Rutjes <arne123@gmail.com>
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.71%. Comparing base (19a597f) to head (19ff7dd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   36.71%   36.71%           
=======================================
  Files          82       82           
  Lines       11661    11661           
=======================================
  Hits         4281     4281           
  Misses       7038     7038           
  Partials      342      342           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

❌ OZ Hardhat Compatibility — 1 regression, 🎉 12 fixed

Regressions (1)

  • VotesExtended vote with timestamp run votes workflow getPastTotalSupply reverts if block number >= current block: Error in "ERC5805FutureLookup" custom error: Error in the 2nd argument assertion: expected 1788438095 to equal 1788438094.

Stale baseline entries (12) — remove these

  • AccessManager admin operations subject to a delay #setRoleAdmin restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • AccessManager admin operations subject to a delay #setRoleGuardian restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • AccessManager admin operations subject to a delay #setGrantDelay restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • AccessManager admin operations subject to a delay #setTargetAdminDelay restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • AccessManager admin operations not subject to a delay #setTargetFunctionRole restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • AccessManager admin operations not subject to a delay role admin operations #grantRole restrictions when the call does not come from the manager (msg.sender != manager) when the function requires the caller to be granted with a role other than PUBLIC_ROLE when the required role is granted to the caller when role granting is not delayed when caller has no execution delay succeeds via execute
  • UUPSUpgradeable upgrade to upgradeable implementation with call
  • ERC721Wrapper onERC721Received mints a token to from
  • Create2 deploy deploys a contract without constructor
  • GovernorProposalGuardian using $ERC20Votes "before each" hook for "deployment check"
  • GovernorProposalGuardian using $ERC20VotesTimestampMock cancel proposal during active state "before each" hook for "from proposal guardian"
  • GovernorProposalGuardian using $ERC20VotesTimestampMock set proposal guardian from governance
Full breakdown — 5524 passed, 890 failed, 1 skipped (6415 total, 86.1% passing)

By suite

  • access: 409/603 passing (68%)
  • crosschain: 44/48 passing (92%)
  • finance: 8/16 passing (50%)
  • governance: 248/553 passing (45%)
  • metatx: 26/32 passing (81%)
  • proxy: 287/320 passing (90%)
  • token: 1799/1882 passing (96%)
  • utils: 2703/2960 passing (91%)

Expected failures by cause (607)

  • max-code-size: 212
  • execution reverted: 129
  • hardhat-time-rpc: 93
  • fixed-timestamp: 35
  • subcall-effect-lost: 31
  • fixed-block-number: 23
  • hardhat_setStorageAt: 17
  • gas required exceeds allowance (10000000): 12
  • eth_getProof: 6
  • no private key available for address 0x893bACb707C0C0D9A46a3EaEA2c3B44DF449137B: 5
  • Expected transaction to be reverted with custom error 'FailedCall', but it reverted with custom error 'TimelockUnexpectedOperationState': 4
  • Expected transaction to be reverted with custom error 'InvalidAccountNonce', but it reverted with custom error 'ERC3009InvalidAuthorizationTime': 4
  • evm_setAutomine: 3
  • execfailure-dropped-not-committed: 3
  • hardhat_setBalance: 3
  • no private key available for address 0xFBa2b1B32da78e5021960907ad9fE9700FBB54E4: 3
  • out of gas: 3
  • transaction already pending: 3
  • Expected transaction to be reverted with custom error 'FailedCall', but it didn't revert: 2
  • estimate-gas-allowance-not-revert: 2
  • no private key available for address 0x0B306BF915C4d645ff596e518fAf3F9669b97016: 2
  • no private key available for address 0x8f119cd256a0FfFeed643E830ADCD9767a1d517F: 2
  • Expected transaction to be reverted with custom error 'ERC3009InvalidAuthorizationTime', but it didn't revert: 1
  • Expected transaction to be reverted with custom error 'TimelockUnexecutedPredecessor', but it reverted with custom error 'TimelockUnexpectedOperationState': 1
  • Expected transaction to be reverted with panic code 0x01 (Assertion error), but it reverted with a custom error: 1
  • could not decode result data (value="0x", info={ "method": "getValue", "signature": "getValue()" }, code=BAD_DATA, version=6.16.0): 1
  • expected '0xd923b66564ef79bafe23ab4091e16f948a6…' to equal '0x5e751a285ce1015671f198ea8ccc2c64305…': 1
  • expected 36000 to equal 4919.: 1
  • expected 4919 to equal 0.: 1
  • hardhat-block-rpc: 1
  • hardhat_impersonateAccount: 1
  • no private key available for address 0xc6e7DF5E7b4f2A278906862b61205850344D4e7d: 1

Run go run ./cmd/baseline update --suite oz-hardhat to accept the expected regressions and drop the fixed entries, then commit the updated baseline.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

Perf Smoke — CI baseline (lower-bound against test committer)

Metric Value
Throughput 480.36 tx/s
Invalid rate 0.000000
Conflict rate 0.000000

Workflow run

@arner arner added the bug Something isn't working label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant