change evaluate RequestId for update config #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfi79
force-pushed
the
2-part-bft-update-config
branch
from
5facf86 to
5f5b50a
Compare
yacovm
reviewed
Dec 27, 2023
pfi79
force-pushed
the
2-part-bft-update-config
branch
2 times, most recently
from
41726a5 to
9bb8799
Compare
yacovm
reviewed
Dec 28, 2023
yacovm
reviewed
Dec 28, 2023
orderer/consensus/smartbft/util.go
Outdated
| return types.RequestInfo{} | ||
| } | ||
|
|
||
| req, err = ri.unwrapReqFromEnvelop(configEnvelope.LastUpdate) |
pfi79
force-pushed
the
2-part-bft-update-config
branch
from
9bb8799 to
557c936
Compare
yacovm
reviewed
Dec 28, 2023
yacovm
reviewed
Dec 28, 2023
pfi79
force-pushed
the
2-part-bft-update-config
branch
from
557c936 to
5f8f833
Compare
yacovm
reviewed
Dec 28, 2023
| if err != nil { | ||
| v.Logger.Errorf("Error verifying config update: %v", err) | ||
| return types.RequestInfo{}, err | ||
| } | ||
|
|
||
| return v.ReqInspector.RequestID(rawRequest), nil |
There was a problem hiding this comment.
maybe check if it returns the zero value (empty request ID) then return error?
pfi79
force-pushed
the
2-part-bft-update-config
branch
from
5f8f833 to
5059e96
Compare
Signed-off-by: Fedor Partanskiy <[email protected]>
pfi79
force-pushed
the
2-part-bft-update-config
branch
from
5059e96 to
ab65998
Compare
yacovm
reviewed
Dec 28, 2023
yacovm
approved these changes
Dec 28, 2023
pfi79
added a commit
to scientificideas/fabric
that referenced
this pull request
Dec 28, 2023
Signed-off-by: Fedor Partanskiy <[email protected]> (cherry picked from commit fc588b5) Signed-off-by: Fedor Partanskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation and in the examples, the channel update transaction is send to one and only one orderer. Like in raft. The smartbft features are not used.
What's happening?
When an orderer receives a channel update transaction, it takes the current channel config and applies the update to it and re-signs the transaction. It then sends it to the smartbft consensus. Total 7 different transactions appear in the consensus.
My current solution fixes the error. RequestID will be calculated differently for channel update transactions.
After this change, the channel update can be sent out as a bft.