Skip to content

fix: test has race condition on ws before connect with DX callbacks #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

EnriqueL8
Copy link
Contributor

Proposed changes

Fixes #1636 (comment)

h.Start() create the WS connection and in the before connect we added a callback handler DXConnect(). The test used to connect then add the handlers so sometimes the test might take longer so on reconnect the handler would be there but not the DXConnect mock.

Actually the test should add all the handlers before staring the FFDX plugin, this is the fix.

FYI @onelapahead


Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

@EnriqueL8 EnriqueL8 requested a review from a team as a code owner March 12, 2025 11:47
@EnriqueL8 EnriqueL8 mentioned this pull request Mar 12, 2025
8 tasks
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (1856c5c) to head (4edf8cd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1658   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         339      339           
  Lines       29780    29780           
=======================================
  Hits        29768    29768           
  Misses          8        8           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peterbroadhurst peterbroadhurst merged commit 35bc1f2 into main Mar 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants