stream bulk #9308
Closed
stream bulk #9308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivaji-kharse
force-pushed
the
shiva/stream-bulk
branch
from
b271d82 to
fe0f67d
Compare
github-actions
bot
added
area/testing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if err == nil { | ||
| pDir := filepath.Join(basePath, entry.Name(), "p") | ||
| if _, err := os.Stat(pDir); err == nil { | ||
| groupDirs[uint32(groupID)] = pDir |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
To fix the problem, we need to ensure that the integer value obtained from strconv.Atoi is within the bounds of the uint32 type before performing the conversion. This can be done by adding a check to ensure the value is non-negative and does not exceed the maximum value of uint32.
The best way to fix this is to use strconv.ParseUint with a bit size of 32, which directly parses the string into a uint32 value, ensuring that the value is within the valid range for uint32. This approach avoids the need for additional bounds checking.
Suggested changeset
1
edgraph/import.go
| @@ -127,3 +127,3 @@ | ||
| if entry.IsDir() { | ||
| groupID, err := strconv.Atoi(entry.Name()) | ||
| groupID, err := strconv.ParseUint(entry.Name(), 10, 32) | ||
| if err == nil { |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
|
|
shivaji-kharse
force-pushed
the
shiva/stream-bulk
branch
2 times, most recently
from
57ab93a to
2d973be
Compare
shivaji-kharse
force-pushed
the
shiva/stream-bulk
branch
from
2d973be to
22fb001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you made here.
Checklist
CHANGELOG.mdfile describing and linking tothis PR
docs repo staged and linked here
Instructions
syntax, leading with
fix:,feat:,chore:,ci:, etc.link to the bug.
[x]syntax.back and check the box later.
Instructionsline and everything below it, to indicate you have read and arefollowing these instructions. 🙂
Thank you for your contribution to Dgraph!