Refactor/service token #101
Conversation
refactor team invitation
Auth bug/fix
…path Refactor/verifier api path
| appId: string, | ||
| user, | ||
| ): Promise<{ access_token; expiresIn; tokenType }> { | ||
| const context = Context.idDashboard; |
There was a problem hiding this comment.
is there any where else in this function , use of this variable context ??
I can see its used in const sessionId = ${appId}_${context};
but if we do not use it anywhere elese then we can directly use this like const sessionId = ${appId}_${Context.idDashboard}` ?
| public async getAccessToken(data, expiresin = 4) { | ||
| const secret = this.config.get('JWT_SECRET'); | ||
| const token = await this.jwt.signAsync(data, { | ||
| expiresIn: expiresin.toString() + 'h', |
There was a problem hiding this comment.
what if I want to issue tokens in like min , I can not do becuae the expiry is always in hourh?
| subdomain: app.subdomain, | ||
| sessionId, | ||
| }; | ||
| return this.getAccessToken(dataToStore, 12); |
There was a problem hiding this comment.
can we keep this expiry 12 some where in one place? so that we can look at that file and would know whats this exipry for?
| sessionId, | ||
| }; | ||
| await this.storeDataInRedis(grantType, app, accessList, sessionId); | ||
| return this.getAccessToken(tokenPayload, 12); |
There was a problem hiding this comment.
can we keep this expiry 12 some where in one place? so that we can look at that file and would know whats this exipry for?
| sessionId, | ||
| JSON.stringify(creditPayload), | ||
| 'EX', | ||
| 5 * TIME.MINUTE, |
There was a problem hiding this comment.
Also keep all redis related expiry at one place.
| customerOnboardingData.kycSubdomain, | ||
| sessionId: kycRedisKey, | ||
| }, | ||
| 4, |
There was a problem hiding this comment.
Please keep this expiry 4 somewhere at one place
src/utils/time-constant.ts
Outdated
| VERIFIER_TOKEN: { | ||
| name: 'verifierPageToken', | ||
| expiry: 30 * TIME.MINUTE, | ||
| jwtExpiry: 0.5, |
There was a problem hiding this comment.
Please keep this expiry 0.5 somewhere at one place
| sessionId: ssiServiceId, | ||
| subdomain: ssiServiceDetail.subdomain, | ||
| }, | ||
| 0.5, |
There was a problem hiding this comment.
Please keep this expiry 0.5 somewhere at one place
| sessionId: appId, | ||
| subdomain: kycServiceDetail.subdomain, | ||
| }, | ||
| 0.5, |
There was a problem hiding this comment.
Please keep this expiry 0.5 somewhere at one place
| Logger.log('generateAccessToken() method: ends....', 'AppAuthService'); | ||
|
|
||
| return { access_token: token, expiresIn, tokenType: 'Bearer' }; | ||
| redisClient.set(sessionId, JSON.stringify(payload), 'EX', TIME.WEEK); |
There was a problem hiding this comment.
Lets keep expiry in one place for reddis
🎯 Purpose
Why is this change needed? (problem it solves or value it adds)
📝 Changes
🔄 Type
🧪 Testing
How did you test this? (unit/integration/manual)
✅ Checklist