ENGTAI-69966: Add compression config #170
Conversation
| google.protobuf.BoolValue enable_grpc_loadbalancing = 9; | ||
|
|
||
| // Enable compression | ||
| google.protobuf.BoolValue compression_enabled = 10; |
There was a problem hiding this comment.
not sure if otel supports other compression than gzip, do we want to take that input as an enum?
There was a problem hiding this comment.
Nope. Docs says just "gzip" for now. https://github.com/open-telemetry/opentelemetry-go/blob/ffeeee82a84a22216c39c5e52a999a3bc6d6ec4d/exporters/otlp/otlptrace/otlptracegrpc/options.go#L120
const (
// NoCompression represents that no compression should be used.
NoCompression Compression = iota
// GzipCompression represents that gzip compression should be used.
GzipCompression
)
There was a problem hiding this comment.
Oh okay, I still feel an Enum might be more future proof.
|
Also since you had gotten rid of hypertrace agent directory go.mod file, shouldn't we be using just the traceable agent config? |
|
agree w/ @varkey98 I think issue is goagent-src still uses/loads configs separately.. but at this point there is no reason not to switch to using a single config. (it'll be some work to migrate tpa/ebpf) away from using 2 configs.. but should make everything easier/simpler once done. |
|
yes. I thought about doing it in Traceablea/agent-config but backed off since it would be quite a huge lift. The changes have to be propagated to multiple agents using the config. |
No description provided.