Skip to content

Make gRPC Client Deadline B/W GQL and Entity Service Configurable #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suddendust opened this issue Jul 9, 2021 · 1 comment
Open

Comments

@suddendust
Copy link
Contributor

Use Case

We want to make gRPC client deadline from GQL -> Entity Service configurable.

Proposal

If you look at https://github.com/hypertrace/hypertrace-graphql/blob/cef8ab9b579df1208d2fc783209bf0416021ce94/hypertrace-graphql-entity-schema/src/main/java/org/hypertrace/graphql/entity/dao/GatewayServiceEntityDao.java#L80, the client deadline is hardcoded to 10s. We want to increase this but since it is not configurable, we will have to make a code change.

@aaron-steinfeld
Copy link
Contributor

aaron-steinfeld commented Jul 9, 2021

+1 - this can be added in the same way the connection details are (although I think it sounds like you're looking for the gateway service timeout, rather than entity service) - accessed via the typed config object, defaulted/read from the application.conf file and overridable in helm values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants