Gateway-Service Client Timeout Config #91
Conversation
… added fallback configuration
… added fallback configuration
suddendust
changed the title
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
============================================
- Coverage 22.34% 22.26% -0.09%
Complexity 66 66
============================================
Files 64 64
Lines 1584 1590 +6
Branches 49 49
============================================
Hits 354 354
- Misses 1223 1229 +6
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Done |
|
The coverage seems to have gone down as these three classes have 0% coverage and this PR increases the total instructions. Should UTs for these three classes be added in this PR @aaron-steinfeld? |
Not necessary for these changes - testing config read is generally more trouble than it's worth if we're working with primitives. The tests start duplicating the config and then you end up testing your test's config, rather than the one you'll use at runtime. Exception of course when we're doing something fancier with config (building data structures, class loading, deserializing objects etc). On the DAO classes, we structure them such that they don't really have any logic and the compiler can more or less enforce correctness. So if you'd like to add tests for them, I'll happily approve, but I think there's much higher value classes to target. |
* feat: add support for attribute expressions * feat: expression support in filter and sorting * refactor: move stuff around * refactor: more refactoring * chore: temp for testing integration * chore: more cleanup * chore: clenaup dependencies, fix tests
Description
These changes are in context of: hypertrace/hypertrace-core-graphql#69. Currently, we hardcode the deadline as 10s. Now, GATEWAY_SERVICE_DEADLINE is read from application.conf
Testing
Deployed and tested the application manually. I am still seeing if I can write a UT for check if config value is being loaded properly.
Checklist:
This PR is dependent on: hypertrace/hypertrace-service#99