fix: restore netty constraint #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-steinfeld
commented
Sep 24, 2024
| @@ -11,6 +11,9 @@ dependencies { | |||
| api("io.grpc:grpc-context") | |||
| api("io.grpc:grpc-api") | |||
| api("io.grpc:grpc-inprocess") | |||
| api(platform("io.netty:netty-bom:4.1.108.Final")) { | |||
There was a problem hiding this comment.
My mistake - I thought this was an old constraint since it wasn't being flagged on this repo and removed it. But it's actually still used upstream when consuming grpc (where we actually bring in netty).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=========================================
Coverage 72.32% 72.32%
Complexity 172 172
=========================================
Files 25 25
Lines 524 524
Branches 26 26
=========================================
Hits 379 379
Misses 121 121
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tim-mwangi
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore netty constraint