Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request response payload capture verify by smoke test #273

Conversation

samarth-gupta-traceable
Copy link
Contributor

Request response payload capture verify by smoke test

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@samarth-gupta-traceable samarth-gupta-traceable marked this pull request as ready for review February 25, 2021 06:07
traces.getFilteredAttributeValue("http.response.body") == stringBody

and: "Response body should be same as received response body"
traces.getFilteredAttributeValue("http.response.body") == responseBody
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be duplicated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

import org.testcontainers.containers.wait.strategy.Wait
import org.testcontainers.containers.wait.strategy.WaitStrategy

@Ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create an issue and add a link here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to glassfish startup issues: #276

import java.time.Duration
import org.testcontainers.containers.wait.strategy.Wait
import org.testcontainers.containers.wait.strategy.WaitStrategy

@Ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is tomee also failing? If so create an issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the v.15.0 release did not have test for tomee . However it is present in latest code.
The the image matrix that is currently published is based on v.15.0 release so tomee test container images are missing in docker hub.
if you look for changes in current PR in file: smoke-tests/matrix/build.gradle
I have added config to publish the same.
Once this PR is merged, images will be published and I will create a follow up PR to enable this with new image tags.

@samarth-gupta-traceable samarth-gupta-traceable merged commit a6ed684 into hypertrace:main Feb 25, 2021
@samarth-gupta-traceable samarth-gupta-traceable deleted the request_response_varify_smoke_test branch February 25, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants