Instrument vertx client directly #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
shashank11p
reviewed
Apr 22, 2021
| BoundedCharArrayWriter buffer = | ||
| InstrumentationContext.get(MultiMap.class, BoundedCharArrayWriter.class) | ||
| .get(request.headers()); | ||
| if (buffer != null) { |
There was a problem hiding this comment.
Dont we want to check if
(HypertraceConfig.get().getDataCapture().getHttpBody().getRequest().getValue()
&& ContentTypeUtils.shouldCapture(contentType))
There was a problem hiding this comment.
we don't have to check it here bc the buffer is null if the body shouldn't be captured.
shashank11p
reviewed
Apr 22, 2021
| buffer = BoundedBuffersFactory.createWriter(); | ||
| contextStore.put(request.headers(), buffer); | ||
| } | ||
| buffer.write(chunk); |
There was a problem hiding this comment.
Why are we calling this here and in EndRequestAdvice both?
There was a problem hiding this comment.
yes, this writes a chunk and in the end method it as well writes a chunk and sends the request.
shashank11p
reviewed
Apr 22, 2021
| public void handle(Buffer event) { | ||
| String responseBody = event.getString(0, event.length()); | ||
| if (span.isRecording()) { | ||
| span.setAttribute(HypertraceSemanticAttributes.HTTP_RESPONSE_BODY, responseBody); |
There was a problem hiding this comment.
Should we also check if we should capture response body?
There was a problem hiding this comment.
not needed as this is reached only after the check from the previous instrumentation point.
pavolloffay
force-pushed
the
vertx-web-fix
branch
from
53371f3 to
a3b1544
Compare
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #310