Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing snyk running on forks #325

Merged
merged 3 commits into from
Jun 21, 2021
Merged

Fix failing snyk running on forks #325

merged 3 commits into from
Jun 21, 2021

Conversation

pavolloffay
Copy link
Member

No description provided.

@pavolloffay
Fix failing snyk running on forks
08d7ef4 
Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay
specify fetch
8407f84 
Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay
Copy link
Member Author

The issue is that the SNYK_TOKEN is not added to the build. It worked in the ht-service https://github.com/hypertrace/hypertrace-service/runs/2876248502#step:4:5

@pavolloffay
Fix PR target branch
0e56da1 
Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay
Copy link
Member Author

The solution is to use pull_request_target conf in the workflow config e.g. https://github.com/hypertrace/hypertrace-service/blob/main/.github/workflows/pr-build.yml#L6.

This makes the secrets available to the fork builds https://docs.github.com/en/actions/reference/events-that-trigger-workflows

@pavolloffay pavolloffay merged commit d2da599 into hypertrace:main Jun 21, 2021
@pavolloffay
Copy link
Member Author

@ryandens see now #323 is passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pavolloffay