Skip to content

Conversation

@Bhuvan506
Copy link
Contributor

@Bhuvan506 Bhuvan506 commented Jul 31, 2025

Description

have added custom metrics to the AbstractThrottledPunctuator class to monitor the size of the punctuator task queue and whether the punctuator is processing tasks efficiently.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

…ack total events in eventStore and if the yield condition is hit
@Bhuvan506 Bhuvan506 requested a review from a team as a code owner July 31, 2025 10:59
@avinashkolluru avinashkolluru changed the title ENGTAI-65929: Add custom metrics in AbstractThrottledPunctuator to track total events in eventStore and if the yield condition is hit Add custom metrics in AbstractThrottledPunctuator to track total events in eventStore and if the yield condition is hit Jul 31, 2025
avinashkolluru
avinashkolluru previously approved these changes Aug 4, 2025
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.93%. Comparing base (f555a3e) to head (424d680).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ework/punctuators/AbstractThrottledPunctuator.java 52.94% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #108      +/-   ##
============================================
- Coverage     75.28%   74.93%   -0.36%     
- Complexity      241      244       +3     
============================================
  Files            44       44              
  Lines          1064     1085      +21     
  Branches         87       89       +2     
============================================
+ Hits            801      813      +12     
- Misses          228      234       +6     
- Partials         35       38       +3     
Flag Coverage Δ
unit 74.93% <52.94%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Bhuvan506 Bhuvan506 merged commit 833262b into hypertrace:main Aug 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants