Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka streams metrics with common app id tag #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laxmanchekka
Copy link
Contributor

Description

Common application id tag for all kafka streams applications

Testing

Manual testing.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

NA.

@github-actions
Copy link

Unit Test Results

  9 files  ±0    9 suites  ±0   3s ⏱️ -1s
41 tests ±0  41 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
59 runs  ±0  59 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit c20e217. ± Comparison against base commit e670394.

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Merging #50 (c20e217) into main (e670394) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main      #50      +/-   ##
============================================
+ Coverage     72.50%   72.59%   +0.08%     
  Complexity      130      130              
============================================
  Files            24       24              
  Lines           611      613       +2     
  Branches         53       53              
============================================
+ Hits            443      445       +2     
  Misses          150      150              
  Partials         18       18              
Flag Coverage Δ
unit 72.59% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/core/kafkastreams/framework/KafkaStreamsApp.java 57.47% <100.00%> (+1.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant