name single threads of kafka live event listener #97
Conversation
Test Results15 files ±0 15 suites ±0 30s ⏱️ ±0s Results for commit 0d5b2b0. ± Comparison against base commit f555a3e. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
| @@ -101,7 +101,7 @@ class ListenerThreadFactory implements ThreadFactory { | |||
| private final String name; | |||
|
|
|||
| public ListenerThreadFactory(String consumerName) { | |||
| this.name = "kafka-live-event-listener-" + consumerName; | |||
| this.name = "kafka-live-event-listener-" + consumerName + "-" + System.currentTimeMillis(); | |||
There was a problem hiding this comment.
Is it common pattern to add time in name?
There was a problem hiding this comment.
I added here intentionally to detect if we have multiple threads for same consumer name
There was a problem hiding this comment.
Ideally for one topic there should be only one live event listener hence one thread only. But if it is wrongly used (calling build again and again instead of only once) there might be more than one, which we want to detect and fix
There was a problem hiding this comment.
If there are 8 StreamThread, there will be 8 Consumers.
If, its more than that, who is caller? How would we fix this? I think, is this called by our application code or by kafka framework itself?
There was a problem hiding this comment.
If there are 8 StreamThread, there will be 8 Consumers.
No even if there are 8 stream threads we only want one consumer per topic - singleton instance
There was a problem hiding this comment.
If, its more than that, who is caller? How would we fix this? I think, is this called by our application code or by kafka framework itself?
This is used by application code, mainly to listen to change events. If we see more than one thread for a consumer name that means we are rebuilding live event listener under some condition, which is wrong. To fix, you might need to organise the building of live event listener to the place where code is exactly once executed - guice singleton or build topology and pass it down appropriately
| private final String name; | ||
|
|
||
| public ListenerThreadFactory(String consumerName) { | ||
| this.name = "kafka-live-event-listener-" + consumerName + "-" + System.currentTimeMillis(); |
There was a problem hiding this comment.
| this.name = "kafka-live-event-listener-" + consumerName + "-" + System.currentTimeMillis(); | |
| this.name = "kafka-live-event-listener-" + consumerName + "-" + String.valueOf(System.currentTimeMillis()); |
No description provided.