Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve iframe functionality #528

Merged
merged 2 commits into from
Jan 7, 2025
Merged

improve iframe functionality #528

merged 2 commits into from
Jan 7, 2025

Conversation

NoahSaso
Copy link
Collaborator

@NoahSaso NoahSaso commented Jan 6, 2025 •
edited
Loading

This adds the following to the useIframe hook:

  • return a function to trigger the iframe wallet keystore change event so that the calling app can inform the nested iframe app that wallet details have changed
  • return the iframe instance so that the caller can interact directly with the saved iframe ref, avoiding the need to save duplicates

This also updates to the latest Cosmiframe, to enable chain ID specific signer overrides as well as regex origins.

@NoahSaso NoahSaso force-pushed the noah/expand-iframe-api branch from 58b532e to dd62fc5 Compare January 7, 2025 18:53
@NoahSaso NoahSaso changed the title add more fields to useIframe hook return improve iframe functionality Jan 7, 2025
@NoahSaso NoahSaso force-pushed the noah/expand-iframe-api branch from dd62fc5 to 6072379 Compare January 7, 2025 18:56
@NoahSaso NoahSaso requested a review from pyramation January 7, 2025 18:57
@pyramation pyramation merged commit 6588b38 into main Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyramation pyramation Awaiting requested review from pyramation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoahSaso @pyramation