feat/use Comet Client

[hoangdv2429]

Close #469

This PR will update the use of tendermint34Client (deprecated type) with cometClient, type of client will be dynamically chosen on time of creation.

Only the function used to create the client is different. Everything else remain backward compatible

[hoangdv2429]

@Zetazzz Can you help me with the e2e test sir ? I'm pretty sure we already have connectComet at the new version.

[Zetazzz]

@Zetazzz Can you help me with the e2e test sir ? I'm pretty sure we already have connectComet at the new version.

Hi, great work, Thank you very much!

Ok, I'll take a look on that

[Zetazzz]

@Zetazzz Can you help me with the e2e test sir ? I'm pretty sure we already have connectComet at the new version.

Hi, I've checked the function 'connectComet' has not been published in the latest version of @cosmjs/tendermint-rpc yet, so e2e can't build without the function.

So let's just wait for it.

[Zetazzz]

And could you please add a flag 'rpcClients.useConnectComet' to control how users generate with the function or not. I think in this way, we let users to choose.

Thank you very much!

[hoangdv2429]

I will add it soon. Thank you for reviewing.

[hoangdv2429]

@Zetazzz Hii, sorry to ping you at this hour. I’m not sure but there is a lot of changes to the fixtures when I run yarn test:watch from the PR that I’m working on and those changes doesn’t relate to the changes I make. Can you have a look ? Thank you!

[Zetazzz]

@Zetazzz Hii, sorry to ping you at this hour. I’m not sure but there is a lot of changes to the fixtures when I run yarn test:watch from the PR that I’m working on and those changes doesn’t relate to the changes I make. Can you have a look ? Thank you!

Hi, no problem at all. And there're some changes posted recently, so please try to re-build(yarn build) before you run test. if that still happen, you can check in those into this PR and let's figure out.(please make sure to backup if it's necessary)

And if things in fixtures are conflict, feel free to ignore, delete and then re-gen them with your merged logic code.

[Zetazzz]

Hi, @hoangdv2429

"@cosmjs/tendermint-rpc": "^0.32.1" seems ready.

So I guess we can proceed this PR now.

Please use a flag 'rpcClients.useConnectComet' to control whether we use connectComet or the old way.
And you can use v-next/telescope-v4 to test the flag and generated code.

Thank you very much!

[hoangdv2429]

I'm getting this weird error when running `yarn` or `yarn build`. I think the import path are misalign between starship and telescope. Have you ever encountered this before ?

[hoangdv2429]

cc @Zetazzz thank you!

[Zetazzz]

I'm getting this weird error when running yarn or yarn build. I think the import path are misalign between starship and telescope. Have you ever encountered this before ?

are those versions of cosmjs the same in telescope and starship folder?

[hoangdv2429]

I think this dependency only exists in starship.

[Zetazzz]

I think this dependency only exists in starship.

I see, let me take a look

[Zetazzz]

I think this dependency only exists in starship.

There're deps between cosmjs submodules, so I guess we should make all these the latest version:

"@cosmjs/stargate": "0.29.3",
"@cosmjs/tendermint-rpc": "^0.31.2",

[hoangdv2429]

Thank you I will be checking on it tomorrow. That's probably the reason 🙏

[webmaster128]

Jupp, this is what you need

[webmaster128]

You should really need this case distinction long term. The first case should work everywhere. However, feel free to keep it for a trial-period.

[hoangdv2429]

I discussed with @Zetazzz and he wants to make it into an option instead of default behavior. wdyt @Zetazzz ?

[hoangdv2429]

@webmaster128 @Zetazzz thank you sirs. I'll update it.

[hoangdv2429]

Need to make another issue for upgrading all the deps.