Remove code related to NLM load sending #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertm
force-pushed
the
remove-nlm-load-sending
branch
from
909e0dc to
6fcf4f0
Compare
ArneBab
reviewed
Nov 22, 2024
|
Thank you for the many explanatory comments in message handling parts (including the concurrency warnings). These are critical and comments there should easy maintenance a lot! |
|
I'm not aware of adding any explanatory comments in the message handling parts; those are probably attributed to me due to indentation changes (a few outer |
This code was effectively inactive since 2013 (which is when the FIXME in PeerNode.makeLoadStats was added: "re-enable when try NLM again"). Removing the related code not only gets rid of a few hundred lines of code, but also slightly reduces the (huge) number of things PeerNode needs to keep track of and simplifies the NPF logic substantially. Note: this does not remove receiving of load stats from peer nodes.
bertm
force-pushed
the
remove-nlm-load-sending
branch
from
6fcf4f0 to
f7fa0c4
Compare
|
Rebased on |
|
I now reviewed directly in Emacs instead of on github and there (with ignore whitespace) this was clear to review. Merged — thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was effectively inactive since 2013 (which is when the FIXME in PeerNode.makeLoadStats was added: "re-enable when try NLM again").
Removing the related code not only gets rid of a few hundred lines of code, but also slightly reduces the (huge) number of things PeerNode needs to keep track of and simplifies the NPF logic substantially.
Note: this does not remove receiving of load stats from peer nodes.