Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove square brackets from display names before using in mention #6912

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Mar 19, 2025

Depends on #6908

Closes #6891

Remove any appearance of [ and ] from display-name mentions, since those characters are reserved to delimit the display name itself.

This is something that is rare to occur, and in most cases dropping those characters should not cause any confusion.

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (61173a4) to head (f486c1b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6912   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files         273      273           
  Lines       10574    10576    +2     
  Branches     2545     2545           
=======================================
+ Hits        10514    10516    +2     
  Misses         60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robertknight
Copy link
Member

Slack thread with info on the 16 LMS users who had used square brackets in their display name. Uses include:

  • Organizational affiliation
  • Pronouns
  • Aliases

@acelaya acelaya force-pushed the up-to-date-unwrapped-mentions branch from 9c2ea67 to 3b8b249 Compare March 20, 2025 09:03
Base automatically changed from up-to-date-unwrapped-mentions to main March 20, 2025 09:06
@acelaya acelaya force-pushed the mention-escape-brackets branch from 0e8c04a to f486c1b Compare March 20, 2025 09:09
@acelaya acelaya merged commit 3a978ed into main Mar 20, 2025
4 checks passed
@acelaya acelaya deleted the mention-escape-brackets branch March 20, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape square brackets in display names when used in mentions
2 participants