Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(groups): enforce priority value constraint #9371

Closed
wants to merge 2 commits into from

Conversation

nnyyxxxx
Copy link
Contributor

@nnyyxxxx nnyyxxxx commented Feb 8, 2025

fixes #8990

@nnyyxxxx nnyyxxxx changed the title fix(groups): enforce priority value fix(groups): enforce priority value constraint Feb 8, 2025
@nnyyxxxx nnyyxxxx marked this pull request as draft February 8, 2025 22:57
@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Feb 8, 2025

what is enforcing the range data specified in configdescriptions?

i see that we specify a range, just curious on what is supposed to be enforcing that. Not sure if i am doing it correctly here.

@vaxerski

@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Feb 8, 2025

idk, i guess we do it manually

@nnyyxxxx nnyyxxxx marked this pull request as ready for review February 8, 2025 23:22
@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Feb 8, 2025

extremely confused rn ngl

@nnyyxxxx
Copy link
Contributor Author

nnyyxxxx commented Feb 9, 2025

im going to move the magic numbers to consts in a sec

@nnyyxxxx nnyyxxxx marked this pull request as draft February 9, 2025 00:19
@nnyyxxxx nnyyxxxx marked this pull request as ready for review February 9, 2025 00:39
@vaxerski
Copy link
Member

vaxerski commented Feb 9, 2025

what is enforcing the range data specified in configdescriptions?

Nothing. The description constraints are purely informative.

@nnyyxxxx nnyyxxxx marked this pull request as draft February 9, 2025 16:30
@nnyyxxxx nnyyxxxx closed this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groupbar priority crashes hyprland
2 participants