Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #108 #128

Closed
wants to merge 1 commit into from
Closed

Conversation

quantum9Innovation
Copy link

This is causing a major regression on some Nvidia laptops that leads to the system becoming frozen after returning from suspend. Fixes #125.

This reverts commit 4468981 for the time being.

@vaxerski
Copy link
Member

vaxerski commented Jan 5, 2025

this is not valid, you are literally creating a segfault with this. There is no way this commit is a source of any regression.

@vaxerski vaxerski closed this Jan 5, 2025
@youwen5
Copy link

youwen5 commented Jan 6, 2025

Although reverting the commit was probably not the best fix, I can confirm that after bisecting the aquamarine tree, this commit is somehow causing a sleep regression on at least a few systems. The bisection was performed on NixOS by precisely overriding the aquamarine source and building the rest of Hyprland, etc against it so I'm reasonably confident that there were no residual environmental reasons for the regression besides this exact commit.

@quantum9Innovation , can you verify again that you identified the correct commit by testing your system with aquamarine on this commit versus the one immediately prior, and then send some logs? It is possible that you read the wrong commit from git bisect, but this issue definitely arose from something between 0.5.0 and 0.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permanent black screen after waking up from sleep (s2idle)
3 participants