Skip to content

Add some newlines at the end of files #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add some newlines at the end of files #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
609c1f0
some newlines
tjeyy Aug 10, 2025
5ade391
enable -Wnewline-eof if clang is used
tjeyy Aug 10, 2025
bb5f1ee
test if CI fails
tjeyy Aug 10, 2025
6e0ec3f
nice
tjeyy Aug 10, 2025
d384193
oops
tjeyy Aug 10, 2025
840223a
added comment
tjeyy Aug 11, 2025
2716b95
Merge branch 'main' into tobias/fix-Wno-newline-eof
tjeyy Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ ifeq ($(relaxed_build), on)
$(warning $(NAME) will be built with most compiler warnings deactivated. This is fine if you want to test $(NAME) but will become an issue when you want to contribute code.)
else
LIB_CFLAGS += -Wall -Werror
# Clang: ensure files end with newline. Missing final newlines here triggered
# -Wnewline-eof warnings in downstream projects (e.g., Hyrise).
ifneq (,$(findstring clang,$(shell $(CXX) --version 2>/dev/null)))
LIB_CFLAGS += -Wnewline-eof
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the check is not part of Wall, yes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.
If it was, the CI would have failed earlier.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment that we explicitly add this check for Hyrise?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course!

endif
endif

static ?= no
Expand Down
2 changes: 1 addition & 1 deletion src/SQLParser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ class SQLParser {

} // namespace hsql

#endif
#endif
2 changes: 1 addition & 1 deletion src/SQLParserResult.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,4 @@ class SQLParserResult {

} // namespace hsql

#endif // SQLPARSER_SQLPARSER_RESULT_H
#endif // SQLPARSER_SQLPARSER_RESULT_H
2 changes: 1 addition & 1 deletion src/parser/parser_typedef.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ struct HSQL_CUST_LTYPE {
#define HSQL_LTYPE HSQL_CUST_LTYPE
#define HSQL_LTYPE_IS_DECLARED 1

#endif
#endif
2 changes: 1 addition & 1 deletion src/sql/DropStatement.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ struct DropStatement : SQLStatement {
};

} // namespace hsql
#endif
#endif