Fix: _EnableSelector type (for compatibility, enableSelector does not exist in TypeOptions) - #1858
Merged
Merged
Conversation
… exist in TypeOptions)
Member
|
@ahrjarrett ok for you? |
Member
|
Ah, good catch. @adrai yep, makes sense to me |
Member
|
Thank you... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have updated to v15.7.0, but I encountered a case where type inference with
useTranslation()does not work correctly.In my project, I am using i18next v25.3.x.
(I am aware that updating to v25.4 would resolve the issue.)
Since
enableSelectoris not defined inTypeOptions, type inference is failing.Looking at the peerDependencies, I noticed that
"i18next": ">= 23.2.3"is specified.Considering compatibility, I thought it would be appropriate to handle cases where
enableSelectoris not present inTypeOptions, so I made this PR.Thank you for your consideration.
Checklist
npm run test