Open
Conversation
Collaborator
|
Hi rokroskar |
Author
|
Hi @anawas - I've also looked at the image you build and there are a few problems that make it difficult to use as an interactive workspace image:
I have a working launcher that gets around some of these problems if you'd like to have a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To build the image automatically in renkulab, it's cleaner to have the directory separated from the project.toml since otherwise the buildpack either assumes poetry or that the local package is being installed.
See an example project which is a copy of the original. The Jupyter launcher is built automatically by renkulab from a fork which includes the changes proposed here. See the renku docs for more info on building images from code repositories.