Skip to content

Replace string ref with React.createRef for ScrollView #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace string ref with React.createRef for ScrollView #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { bool, func, number, string } from 'prop-types'

const window = Dimensions.get('window')

const SCROLLVIEW_REF = 'ScrollView'
// const SCROLLVIEW_REF = 'ScrollView' pattern no longer works

const pivotPoint = (a, b) => a - b

Expand Down Expand Up @@ -68,6 +68,8 @@ class ParallaxScrollView extends Component {
viewWidth: window.width
}
this.scrollY = new Animated.Value(0)
// Add this:
this.scrollViewRef = React.createRef(); // it resolve string error instead of use 'ScrollView', now we use this.scrollViewRef = React.createRef();
this._footerComponent = { setNativeProps() { } } // Initial stub
this._footerHeight = 0
}
Expand Down Expand Up @@ -139,7 +141,7 @@ class ParallaxScrollView extends Component {
{React.cloneElement(
scrollElement,
{
ref: SCROLLVIEW_REF,
ref: this.scrollViewRef, // Changed from SCROLLVIEW_REF
style: [styles.scrollView, scrollElement.props.style],
scrollEventThrottle: 1,
// Using Native Driver greatly optimizes performance
Expand All @@ -161,20 +163,21 @@ class ParallaxScrollView extends Component {
/*
* Expose `ScrollView` API so this component is composable with any component that expects a `ScrollView`.
*/
// Update all methods that access refs
getScrollResponder() {
return this.refs[SCROLLVIEW_REF]._component.getScrollResponder()
return this.scrollViewRef.current?._component?.getScrollResponder()
}
getScrollableNode() {
return this.getScrollResponder().getScrollableNode()
return this.getScrollResponder()?.getScrollableNode()
}
getInnerViewNode() {
return this.getScrollResponder().getInnerViewNode()
return this.getScrollResponder()?.getInnerViewNode()
}
scrollTo(...args) {
this.getScrollResponder().scrollTo(...args)
this.getScrollResponder()?.scrollTo(...args)
}
setNativeProps(props) {
this.refs[SCROLLVIEW_REF].setNativeProps(props)
this.scrollViewRef.current?.setNativeProps(props); // also this one
}

/*
Expand Down Expand Up @@ -364,7 +367,7 @@ class ParallaxScrollView extends Component {
<View
ref={ref => {
if (ref) {
this._footerComponent = ref;
ref={this._footerComponent} // also this one
}
}}
style={{ backgroundColor: contentBackgroundColor }}
Expand Down