Skip to content

Conversation

@r1000ru
Copy link

@r1000ru r1000ru commented Oct 28, 2025

Add CRSF telemetry flight modes: WAIT, ERROR, LAND, ANGLE HOLD, HOME RESET, ets
If HOME RESET is active - widget home point will be reseted to current coordinates.

Known issue: if used SPort-based telemetry and this flight modes, INav send value as in ACRO. It is not widget bug.

@r1000ru
Copy link
Author

r1000ru commented Oct 28, 2025

For test i am use XPlane 11 + INav HITL plugin + Inav + receivers ELRS and FrSky TW

@r1000ru r1000ru mentioned this pull request Oct 28, 2025
@robthomson
Copy link
Collaborator

Great. I am, back home now and will double check all works my end then merge.

@robthomson
Copy link
Collaborator

@jaroszmm .. I have tested this with sport and looks like no issues.

Can you please do a test on one of your elrs rigs - if all ok; we can merge.

@MrD-RC
Copy link
Member

MrD-RC commented Oct 30, 2025

It should never show AIR. Airmode is not a flight mode. It is a modifier and applies to all flight modes.

@robthomson
Copy link
Collaborator

@r1000ru ..

I have another PR up

https://github.com/iNavFlight/ETHOS-Telemetry-Dashboard/actions/runs/18935398164

That includes the audio files for this. Maybe you could check all ok on your end?

@r1000ru
Copy link
Author

r1000ru commented Oct 31, 2025

@MrD-RC ACRO or AIR - it is default flight mode value. If used other flight mode (including Air Modifier), we will never get a mention about Air. At the same time, the Air makes adjustments to flight control. I think it's worth mentioning this (especially since it's done on the OSD)

@MrD-RC
Copy link
Member

MrD-RC commented Oct 31, 2025

@MrD-RC ACRO or AIR - it is default flight mode value. If used other flight mode (including Air Modifier), we will never get a mention about Air. At the same time, the Air makes adjustments to flight control. I think it's worth mentioning this (especially since it's done on the OSD)

Not at all. The LUA should match the OSD for consistency. AIR is never displayed in the INAV OSD. It hasn't been for years. As Airmode can apply just as much to Angle or Horizon as to Acro. It would be inconsistent behaviour to show AIR instead of the actual flight mode, which would be Acro. The telemetry code should not be sending AIR at all. It is likely a hang over from when the code was added, probably an import from BetaFlight. Which does incorrectly display AIR.

@MrD-RC
Copy link
Member

MrD-RC commented Oct 31, 2025

Just noticed home reset is in modes too. This is not the right place to have this. It is not a flight mode.

@r1000ru
Copy link
Author

r1000ru commented Nov 1, 2025

@MrD-RC , I am remove AIR mode.
@robthomson I checked everything again with the sounds in ELRS and Smartport. Everything is working fine

@MrD-RC
Copy link
Member

MrD-RC commented Nov 1, 2025

It may be worth checking the master INAV's telemetry/crsf.c file. Modes have been added for:

  • Geofence AUTO
  • Waypoint RTH WRTH
  • Loiter LOTR
  • Turtle mode TURT

@r1000ru
Copy link
Author

r1000ru commented Nov 1, 2025

@MrD-RC , It is very good. I will add these modes

@MrD-RC
Copy link
Member

MrD-RC commented Nov 1, 2025

It's worth keeping the work you already did. Then it will still work with INAV 8 and earlier.

Just for information. The OpenTX telemetry script ignored AIR. it just showed ACRO if AIR was detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants