Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update from PNU #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update from PNU #5

wants to merge 3 commits into from

Conversation

mtap-research
Copy link
Collaborator

  • Declaration and initialization of new variables in the breakthrough.h and breakthrough.cpp file.
  • Non-dimensionalization of solution variables.
  • Implementation of Ergun's equation for velocity calculation.
  • Changed the basis of material balances in the RUPTURA codebase from partial pressure to mole fraction.
  • Added the temperature dependent terms in material balance.
  • Added the energy balance.
  • Addition of Extended Langmuir model for mixture adsorption isotherm.

Implemented by @hassan-azizi

@mtap-research
Copy link
Collaborator Author

@YouriRan can we create a branch called CycleSim so that we can develop there?

@YouriRan
Copy link
Collaborator

Hi Hassan, I think it would be best to work on your own fork. If you feel that this code is ready for review, let me know, then I will review and merge if it's ready.

@mtap-research
Copy link
Collaborator Author

We will do that thanks @YouriRan

@mtap-research
Copy link
Collaborator Author

@YouriRan could you review the code? We have added different numerical discretization scheme and time steps on top of previous commits.

@YouriRan
Copy link
Collaborator

Sure! I will probably have time on Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants