-
-
Notifications
You must be signed in to change notification settings - Fork 16
Updated French translation #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated various French strings for better clarity and consistency. While waiting for the implementation of a translation platform for Echo-Music (like Crowdin or Weblate), I have improved the translation of certain elements into French. I hope everything is correct.
Refactor French strings for improved clarity
Reviewer's GuideImproves and expands the French localization for the Android app by refining many existing translations, normalizing punctuation/wording, adding translator guidance comments, and adding new string entries to support additional app features and settings while aligning terminology across the UI. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 2 issues, and left some high level feedback:
- The
search_yt_musicstring has been changed from a literal search action label to a mood phrase ("De quelle humeur êtes-vous aujourd’hui ?"), which alters the intent of the UI; consider keeping the wording closer to the original meaning (search on YouTube Music) unless the UX was intentionally redesigned. - The
remove_download_playlist_confirmstring remains in English while surrounding strings are in French and its previous French translation was removed; consider translating this entry for consistency with the rest of the locale.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `search_yt_music` string has been changed from a literal search action label to a mood phrase ("De quelle humeur êtes-vous aujourd’hui ?"), which alters the intent of the UI; consider keeping the wording closer to the original meaning (search on YouTube Music) unless the UX was intentionally redesigned.
- The `remove_download_playlist_confirm` string remains in English while surrounding strings are in French and its previous French translation was removed; consider translating this entry for consistency with the rest of the locale.
## Individual Comments
### Comment 1
<location> `app/src/main/res/values-fr/strings.xml:38-47` </location>
<code_context>
+ <string name="today">Aujourd\\’hui</string>
</code_context>
<issue_to_address>
**issue (bug_risk):** Backslashes before apostrophes will show up in the UI instead of acting as escapes.
In Android string resources, apostrophes don’t need escaping (unlike Java/Kotlin). Using `�`-style escapes like `Aujourd\’hui` will render the backslash. Use a plain apostrophe or a typographic one (`Aujourd’hui`), or `’`/`'` if you prefer the HTML entity. The same pattern appears in several strings in this file and should be corrected consistently.
</issue_to_address>
### Comment 2
<location> `app/src/main/res/values-fr/strings.xml:87` </location>
<code_context>
+ <string name="no_uploaded_songs">Aucun titre téléchargé trouvé</string>
+ <string name="no_top_songs">Aucun titre favori disponible</string>
+ <string name="no_cached_songs">Aucun titre en cache trouvé</string>
+ <string name="remove_download_playlist_confirm">Do you really want to remove all \"%s\" playlist songs from the Downloaded Songs storage?</string>
+ <string name="delete_playlist_confirm">Voulez-vous vraiment supprimer la playlist \"%s\" ?</string>
+
</code_context>
<issue_to_address>
**issue (bug_risk):** Confirmation message is in English in the French resources.
This entry is in the French `values-fr` file but remains in English, while the previous version was French. Unless this is intentional, it should be translated to French to stay consistent with the rest of the resource file.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
My sincerest apologies for this unfortunate mistake... I merged my file a little too quickly. 🤦 I'm truly sorry. In my haste, I completely forgot to put a backslash (\) before each apostrophe. I know they shouldn't be removed. So, I've fixed that.
Update strings.xml
While waiting for the implementation of a translation platform (like Crowdin or Weblate), I have improved the translation of certain elements into French.
I hope everything is correct.
I will ensure that the translation is updated to make the application as understandable as possible to users.
Summary by Sourcery
Improve and expand the French localization strings for the Android app, including wording refinements, new UI text entries, and updated guidance comments for translators.
New Features:
Bug Fixes:
Enhancements: