-
-
Notifications
You must be signed in to change notification settings - Fork 16
Refactor French strings for improved clarity #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated French strings in strings.xml for better clarity and consistency.
Reviewer's GuideRefactors and expands the French localization in values-fr/strings.xml, adding upstream documentation comments, new UI strings, and revising many existing translations and plurals for consistency, tone, and clarity across navigation, search, playlists, settings, privacy, and integration features. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- There are several apostrophe/escape inconsistencies (e.g.,
Aujourd\’hui,file d\’attente, mix of straight'vs curly’), which may render incorrectly in XML and should be normalized to the same escaping style used elsewhere in the project. - The string
remove_download_playlist_confirmremains in English while surrounding strings are in French; if this is not intentional it should be localized for consistency with the rest of the file. - For the
minuteplurals, theonecase was changed to literal1 minuteinstead of%d minute, which makes it inconsistent with other plurals and may prevent proper formatting if a non-1 value is ever passed; consider keeping%dfor the singular case as well.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There are several apostrophe/escape inconsistencies (e.g., `Aujourd\’hui`, `file d\’attente`, mix of straight `'` vs curly `’`), which may render incorrectly in XML and should be normalized to the same escaping style used elsewhere in the project.
- The string `remove_download_playlist_confirm` remains in English while surrounding strings are in French; if this is not intentional it should be localized for consistency with the rest of the file.
- For the `minute` plurals, the `one` case was changed to literal `1 minute` instead of `%d minute`, which makes it inconsistent with other plurals and may prevent proper formatting if a non-1 value is ever passed; consider keeping `%d` for the singular case as well.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Updated French strings in strings.xml for better clarity and consistency.
📋 Pull Request Description
Brief description of the changes made in this PR.
🔄 Type of Change
🎯 Related Issues
Fixes #(issue number)
Closes #(issue number)
📱 Testing
📸 Screenshots
If applicable, add screenshots to show the changes.
📋 Checklist
🔍 Additional Notes
Any additional information about the PR.
Summary by Sourcery
Refine and expand the French user-facing strings for the music player to improve clarity, consistency, and coverage of newer features.
New Features:
Enhancements: