Skip to content

Conversation

@Mickael81
Copy link

@Mickael81 Mickael81 commented Jan 5, 2026

Updated French strings in strings.xml for better clarity and consistency.

📋 Pull Request Description

Brief description of the changes made in this PR.

🔄 Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Other: _______________

🎯 Related Issues

Fixes #(issue number)
Closes #(issue number)

📱 Testing

  • I have tested these changes locally
  • I have tested on different devices/Android versions
  • I have tested both FOSS and Full build variants
  • I have verified the app builds successfully

📸 Screenshots

If applicable, add screenshots to show the changes.

📋 Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

🔍 Additional Notes

Any additional information about the PR.

Summary by Sourcery

Refine and expand the French user-facing strings for the music player to improve clarity, consistency, and coverage of newer features.

New Features:

  • Add French strings for additional UI elements such as quick access sections, library empty states, playback queue options, account management, Discord integration, and the home screen widget description.

Enhancements:

  • Improve wording, capitalization, and phrasing of existing French strings for navigation, search, playback controls, settings, privacy, and backup flows to be more natural and consistent.
  • Unify plural resources and terminology (e.g., favourites, queue, cache, playback) for a more coherent French localization across the app.
  • Add guidance comments in the French strings file regarding upstream InnerTune usage, naming, and translation workflow via Weblate.

Updated French strings in strings.xml for better clarity and consistency.
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 5, 2026

Reviewer's Guide

Refactors and expands the French localization in values-fr/strings.xml, adding upstream documentation comments, new UI strings, and revising many existing translations and plurals for consistency, tone, and clarity across navigation, search, playlists, settings, privacy, and integration features.

File-Level Changes

Change Details Files
Document upstream translation rules and scope for the French strings resource file.
  • Added XML comments describing that these strings are upstream InnerTune strings and should not be used for new features
  • Clarified that translators must use InnerTune’s Weblate and that the app name "InnerTune" is replaced with "Echo"
app/src/main/res/values-fr/strings.xml
Standardize French typography, wording, and tone across navigation, playback, and library UI strings.
  • Adjusted various labels for consistency (e.g., mood_and_genres, most_played_albums, sleep_timer, music_player, quick_picks, quick_access)
  • Changed several actions and menu items to more natural French phrases and consistent style (e.g., liked_songs, filter_liked, sort_by_play_time, bitrate, sample_rate)
  • Made snackbar and error messages more idiomatic and clarified meanings (e.g., removed_song_from_playlist, error_timeout)
  • Updated some strings from literal to more user-friendly wording (e.g., search_yt_music now uses a mood prompt instead of a direct search instruction)
app/src/main/res/values-fr/strings.xml
Add missing French strings for new features and UI elements such as discovery rails, library empty states, queue and playlist management, and Discord integration.
  • Introduced new home and library strings (e.g., forgotten_favorites, keep_listening, your_youtube_playlists, library_*_empty, other_versions)
  • Added detailed playlist/queue management strings for empty states, confirmation dialogs, duplicate handling, and bulk like/download operations
  • Expanded player and settings sections with new options (e.g., tempo_and_pitch, action_like_all, action_remove_like_all, player_slider_style, grid_cell_size, queue, auto_load_more, auto_skip_next_on_error)
  • Added login/account management strings (e.g., action_login, action_logout, not_logged_in, switch_account, accounts_count)
  • Added privacy, backup/restore, and integration strings including LrcLib, content filters, screenshot disabling, and Discord RPC information
  • Added widget_description for the music player widget
app/src/main/res/values-fr/strings.xml
Normalize plurals and remove unused quantities for French plural resources.
  • Simplified plurals definitions by removing the unnecessary 'many' quantity and keeping 'one' and 'other' for n_song, n_artist, n_album, n_playlist, n_week, n_month, n_year, and n_selected
  • Updated minute plural resource to use a fixed string for the singular form and a standard %d pattern for the plural form
app/src/main/res/values-fr/strings.xml
Align privacy, settings, and system behavior descriptions with clearer French phrasing and consistent terminology.
  • Rephrased privacy-related strings to use consistent terminology for histories and confirmation questions (listen_history, search_history, pause_history, clearhistory_confirm)
  • Standardized system/default-related labels (e.g., system_default, dark_mode* and dark_theme_* variants, content_language/country)
  • Refined descriptions for cache, storage, and queue behavior (e.g., size_used, persistent_queue_desc, auto_load_more_desc)
  • Tweaked backup/restore messaging to be more natural and explicit in French
app/src/main/res/values-fr/strings.xml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • There are several apostrophe/escape inconsistencies (e.g., Aujourd\’hui, file d\’attente, mix of straight ' vs curly ), which may render incorrectly in XML and should be normalized to the same escaping style used elsewhere in the project.
  • The string remove_download_playlist_confirm remains in English while surrounding strings are in French; if this is not intentional it should be localized for consistency with the rest of the file.
  • For the minute plurals, the one case was changed to literal 1 minute instead of %d minute, which makes it inconsistent with other plurals and may prevent proper formatting if a non-1 value is ever passed; consider keeping %d for the singular case as well.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- There are several apostrophe/escape inconsistencies (e.g., `Aujourd\’hui`, `file d\’attente`, mix of straight `'` vs curly ``), which may render incorrectly in XML and should be normalized to the same escaping style used elsewhere in the project.
- The string `remove_download_playlist_confirm` remains in English while surrounding strings are in French; if this is not intentional it should be localized for consistency with the rest of the file.
- For the `minute` plurals, the `one` case was changed to literal `1 minute` instead of `%d minute`, which makes it inconsistent with other plurals and may prevent proper formatting if a non-1 value is ever passed; consider keeping `%d` for the singular case as well.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant