Skip to content

Conversation

binh-dam-ibigroup
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup commented Aug 14, 2025

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Requires/Blocked by #1032.

This PR isolates MTC-specific features/behaviors that were not initially captured.
As a result, when the MTC extension is enabled in config:

  • Deployments are hidden in the create/edit feed dialogs
  • GTFS editor: new routes are created with different approval/public statuses

In addition, some macros are added to the documentation so that the product name can be configured (e.g. "TRANSIT-data-tools" vs. "Transit Data Manager").

@binh-dam-ibigroup binh-dam-ibigroup changed the title Mtc deploy with dev isolate mtc features Isolate MTC features Aug 14, 2025
@binh-dam-ibigroup binh-dam-ibigroup marked this pull request as ready for review August 21, 2025 18:01
Copy link

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I'm really excited we are reducing our number of dev branches

Comment on lines +15 to +17
extra:
product_name: Arcadis TRANSIT-data-tools
support_email: [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to pull this from the settings.yml where it's already defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that file lives somewhere else doesn't it?

@binh-dam-ibigroup binh-dam-ibigroup added BLOCKED Blocked (waiting on another PR to be merged) Pending ext. approval labels Aug 28, 2025
@binh-dam-ibigroup binh-dam-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Sep 2, 2025
@binh-dam-ibigroup binh-dam-ibigroup merged commit c1d556f into mtc-deploy-with-dev Sep 2, 2025
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the mtc-deploy-with-dev-isolate-mtc-features branch September 2, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants