Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return DSL string for DataDatatype.__repr__() #10726

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NickCrews
Copy link
Contributor

fixes #10391

I can add more tests or otherwise modify them if you think wise, but probably I think what we have here is sufficient.

One sanity check could be a roundtrip check?

for dsl in ["int8", "uint8" ,...]:
    dt = ibis.dtype(dsl)
    assert dsl == str(dt)
    assert dsl == repr(dt)

@github-actions github-actions bot added tests Issues or PRs related to tests datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) labels Jan 26, 2025
@cpcloud
Copy link
Member

cpcloud commented Jan 27, 2025

See my comment on #10391. I don't think we should do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: better repr for DataType
2 participants