Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datatypes): add support for fixed length arrays #10729

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 26, 2025

Add length field to Array datatypes to support fixed-length arrays.

Closes #10719.

@cpcloud cpcloud added feature Features or general enhancements duckdb The DuckDB backend labels Jan 26, 2025
@github-actions github-actions bot added tests Issues or PRs related to tests datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) sql Backends that generate SQL labels Jan 26, 2025
@cpcloud cpcloud force-pushed the fixed-length-array-type branch 7 times, most recently from 677242a to 029e454 Compare January 27, 2025 16:05
@kszucs
Copy link
Member

kszucs commented Jan 28, 2025

Could you please create a follow-up ticket to adjust the hypothesis strategy here?

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, otherwise it LGTM.

@cpcloud cpcloud force-pushed the fixed-length-array-type branch from 029e454 to 9a89674 Compare January 28, 2025 09:36
@cpcloud
Copy link
Member Author

cpcloud commented Jan 28, 2025

Could you please create a follow-up ticket to adjust the hypothesis strategy here?

No need, I adjusted it here and there were no issues!

@cpcloud cpcloud added this to the 10.0 milestone Jan 28, 2025
@cpcloud cpcloud force-pushed the fixed-length-array-type branch from 5b6477b to eb88844 Compare January 28, 2025 09:40
@cpcloud cpcloud force-pushed the fixed-length-array-type branch from eb88844 to a55d734 Compare January 28, 2025 09:59
@github-actions github-actions bot added the clickhouse The ClickHouse backend label Jan 28, 2025
@cpcloud cpcloud enabled auto-merge (squash) January 28, 2025 10:06
@cpcloud cpcloud merged commit d17d53e into ibis-project:main Jan 28, 2025
87 checks passed
@cpcloud cpcloud deleted the fixed-length-array-type branch January 28, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clickhouse The ClickHouse backend datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) duckdb The DuckDB backend feature Features or general enhancements sql Backends that generate SQL tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Improve support for fixed length array in DuckDB
2 participants