Backend-specific primitives #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungoboingo
reviewed
Jun 27, 2023
bungoboingo
reviewed
Jun 27, 2023
hecrj
force-pushed
the
generic-graphics-primitive
branch
from
c415a46 to
2128472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
Customgeneric type and variant toPrimitiveiniced_graphics.Graphical backends can now define their custom primitive type. As a result, we can properly decouple the
tiny-skiadependency fromiced_graphics.This should also lay the foundations for choosing a completely custom, unofficial renderer at runtime.