Fix: (flutter) avoid SDK class name clashes for icon widgets (#559) - #605
Open
gkarasek wants to merge 1 commit into
Open
Fix: (flutter) avoid SDK class name clashes for icon widgets (#559)#605gkarasek wants to merge 1 commit into
gkarasek wants to merge 1 commit into
Conversation
Icon classes that matched dart:core or Flutter types (e.g. Text, List, Map) caused ambiguous import errors with Material. Rename those widgets with an Icon suffix when building the Flutter package. Fixes iconoir-icons#559 Made-with: Cursor
gkarasek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iconoir_flutter, some icon widget classes used the same PascalCase names as Dart / Flutter SDK types (e.g.Text,List,Map), which caused ambiguous import errors alongsidepackage:flutter/material.dart(issue #559).Iconsuffix during the Flutter build (e.g.Text→TextIcon).Breaking change
Apps that imported the affected generated widgets by the old class names must switch to the suffixed names (see
FLUTTER_SDK_CLASS_CONFLICTSinbin/build/targets/flutter/index.js).Fixes #559