Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed new training #27572

Open
wants to merge 53 commits into
base: next
Choose a base branch
from
Open

Proposed new training #27572

wants to merge 53 commits into from

Conversation

GiudGiud
Copy link
Contributor

@GiudGiud GiudGiud commented May 8, 2024

  • Make all steps work
  • add more professional context, with INL graphics and co. Make it more promotional
  • add pre-checked in graphics
  • remove more C++ from systems explanation

This will have to wait for #29072
Doco test failure will be addressed by #29729

There are a few other developments required in there. Mostly bug fixes and a little bit of new capability

what could we do more?

  • add more content in syntax / systems descriptions
  • add more examples
  • add more steps
    • a workbench step
    • a meshing step

Would be good to do this later.

@GiudGiud GiudGiud self-assigned this May 8, 2024
@GiudGiud GiudGiud force-pushed the PR_save_training branch from f155eb1 to aff2e3c Compare May 8, 2024 01:18
@moosebuild
Copy link
Contributor

Job Documentation on aff2e3c wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage on aff2e3c wanted to post the following:

Framework coverage

b3efaa #27572 aff2e3
Total Total +/- New
Rate 85.11% 85.11% +0.00% -
Hits 103108 103109 +1 0
Misses 18044 18043 -1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@github-actions github-actions bot added the stale PRs that have reached or exceeded 90 days with no activity label Aug 28, 2024
@GiudGiud GiudGiud removed the stale PRs that have reached or exceeded 90 days with no activity label Aug 28, 2024
@github-actions github-actions bot added stale PRs that have reached or exceeded 90 days with no activity and removed stale PRs that have reached or exceeded 90 days with no activity labels Dec 7, 2024
@idaholab idaholab deleted a comment from github-actions bot Jan 13, 2025
@idaholab idaholab deleted a comment from github-actions bot Jan 13, 2025
@idaholab idaholab deleted a comment from moosebuild Jan 13, 2025
@moosebuild
Copy link
Contributor

moosebuild commented Jan 13, 2025

Job Documentation, step Docs: sync website on bec6818 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Precheck, step Size check on 5b90683 wanted to post the following:

Warning: This PR changes repo size by 25.74 MiB.

@moosebuild
Copy link
Contributor

moosebuild commented Jan 15, 2025

Job Coverage, step Generate coverage on bec6818 wanted to post the following:

Framework coverage

4d0bbd #27572 bec681
Total Total +/- New
Rate 85.24% 85.23% -0.01% 86.14%
Hits 108456 108558 +102 317
Misses 18781 18814 +33 51

Diff coverage report

Full coverage report

Modules coverage

Inconsistent report tags were found between the head and base reports.
This can happen when reports are missing from either the head or the base.

Inconsistent tags:
module-chemical_reactions-parallel
module-contact-parallel
module-electromagnetics-parallel
module-external_petsc_solver-parallel
module-fluid_properties-parallel
module-fsi-parallel
module-functional_expansion_tools-parallel
module-geochemistry-parallel
module-heat_transfer-parallel
module-level_set-parallel
module-misc-parallel
module-navier_stokes-parallel
module-optimization-parallel
module-peridynamics-parallel
module-phase_field-parallel
module-porous_flow-parallel
module-ray_tracing-parallel
module-rdg-parallel
module-reactor-parallel
module-scalar_transport-parallel
module-solid_mechanics-parallel
module-solid_properties-parallel
module-stochastic_tools-parallel
module-thermal_hydraulics-parallel
module-xfem-parallel

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 86.14% is less than the suggested 90.0%

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on 9b1393c wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/27572/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format bf7a391b5da0313b05c3181a855130d329ea5b12

@moosebuild
Copy link
Contributor

Job Precheck, step Fixup commit check on 78b70d8 wanted to post the following:

The following commit(s) contain fixups:

  • 4fa86f0: fixup! Use flux BCs in water, reduce cp to obtain T profile faster Add postprocessing Precondition each system separately

@GiudGiud GiudGiud force-pushed the PR_save_training branch 2 times, most recently from c5b972d to ea18710 Compare January 23, 2025 03:56
@GiudGiud GiudGiud marked this pull request as ready for review January 23, 2025 14:44
GiudGiud and others added 28 commits January 29, 2025 12:43
- add some text on CI
Have a little more refinement in step 8 w/ adaptivity
Use AD functor dirichlet BC for temperature for coupling purposes
Lower thermal expansion
Add scaling to energy equation to accomodate for bad convergence
…rocessing Precondition each system separately
Use FV
Show FV flow in 3D then do the same transition to 2D for investigating the coupling
- check for nodal variables
- dont seg fault on non-nodal ones
- add support for non-nodal variables
- add more checks
closes idaholab#29741
@@ -1 +1 @@
Subproject commit 8dc9ab6699d0c9c5d9ae03665a2ece62eb339b49
Subproject commit 3ba8fc30775a481abc3663171da785ce47b39bfd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution! This contains a submodule update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants