Added error for when no parameter fits #29734
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Documentation, step Docs: sync website on 3d1467e wanted to post the following: View the site here This comment will be updated on new commits. |
| @@ -16,6 +16,7 @@ | |||
| #include "MultiMooseEnum.h" | |||
| #include "ExecFlagEnum.h" | |||
| #include "MooseObject.h" | |||
| #include "FEProblem.h" | |||
There was a problem hiding this comment.
What is this include needed for?
There was a problem hiding this comment.
That is odd, I don't remember adding that? Doesn't seem like I need it though so I'll go ahead and remove it.
|
Job Coverage, step Generate coverage on 3d1467e wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
loganharbour
requested changes
Jan 24, 2025
| @@ -1156,6 +1156,8 @@ InputParameters::applyParameter(const InputParameters & common, | |||
| // the parameter in the action | |||
| at(local_name)._hit_node = common.getHitNode(common_name); | |||
| } | |||
| else if (!local_exist && !common_exist) | |||
| mooseError("Attempted to apply invalid parameter \"", common_name, "\""); | |||
There was a problem hiding this comment.
Can we add just a little more context to this?
mooseError("InputParameters::applyParameter(): Attempted to apply invalid parameter \"", common_name, "\"");
- added check to applyParameter that throws an error if the provided param does not match any known param - added to applyParameter unit test to ensure an error is thrown closes idaholab#27556
DanielYankura
force-pushed
the
applyParameter_error_check
branch
from
a66e8c0 to
3d1467e
Compare
|
I looked over the errored checks and I think they're unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
Design
Impact
New error check
closes #27556